Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign-tools windows CI: don't major version number #540

Merged
merged 1 commit into from
Oct 25, 2021
Merged

ign-tools windows CI: don't major version number #540

merged 1 commit into from
Oct 25, 2021

Conversation

scpeters
Copy link
Contributor

The ignition-tools cmake package name doesn't include its major version, so disable COLCON_AUTO_MAJOR_VERSION. This is a follow-up to #537, since we were unable to test that with an ign-tools PR until after merging.

# BEGIN SECTION: colcon test for ignition-tools1
[0.561s] �[34mcolcon.colcon_core.package_selection�[0m �[1;30mWARNING�[0m �[33mignoring unknown package 'ignition-tools1' in --packages-select�[0m

Summary: 0 packages finished [0.23s]
# END SECTION
...
# BEGIN SECTION: export testing results
File not found - test_results
0 File(s) copied
Failed with error #4.

@scpeters
ign-tools windows CI: don't major version number
55fbf76 
The ignition-tools cmake package name doesn't include its major
version, so disable COLCON_AUTO_MAJOR_VERSION

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this pull request Oct 25, 2021
Merged
7 tasks
@scpeters scpeters merged commit 1798c64 into master Oct 25, 2021
@scpeters scpeters deleted the scpeters/ign-tools-no-auto-major branch October 25, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey azeey approved these changes

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scpeters @azeey