Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect gz program instead of using CMake module to check for gz-tools #172

Merged
merged 1 commit into from
Jun 25, 2022

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

This branch was broken when gazebosim/gz-tools#96 was merged. This PR fixes the build by addressing gazebo-tooling/release-tools#472 like other libraries did.

Sorry for the disruption, I should have built the entire stack with the gz-tools PR instead of just a few libs.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from nkoenig as a code owner June 24, 2022 23:48
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 24, 2022
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #172 (6dd8e01) into main (184b285) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #172   +/-   ##
=======================================
  Coverage   32.40%   32.40%           
=======================================
  Files           4        4           
  Lines         830      830           
=======================================
  Hits          269      269           
  Misses        561      561           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 184b285...6dd8e01. Read the comment docs.

@chapulina chapulina merged commit ec5244d into main Jun 25, 2022
@chapulina chapulina deleted the chapulina/6/gz_program branch June 25, 2022 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants