Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gz-cmake #96

Merged
merged 6 commits into from
Jun 24, 2022
Merged

Use gz-cmake #96

merged 6 commits into from
Jun 24, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Jun 21, 2022

🎉 New feature

Requires

Summary

Reduce duplication with other Gazebo libraries by depending on gz-cmake.

There's been a previous attempt at migrating to gz-cmake in PR 6, but at the time we decided against it because it would be complicated to support two versions installing the ign executable. With the move to gz (see gazebo-tooling/release-tools#739), that's no longer an issue.

Test it

  • Build this package with colcon
  • Build some package that depends on it, like gz-plugin, and check that the gz plugin CLI works
  • Run colcon test and check that UNIT_gz_TEST and rubocop passed
  • Run colcon build --cmake-target doc, then navigate to build/ignition-tools2/doxygen/html/ and check that the documentation site is correctly generated
  • Run colcon build --cmake-target codecheck and check it passes

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants