Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz CLI Migration : gz-msgs #262

Merged
merged 2 commits into from
Jun 21, 2022
Merged

ign -> gz CLI Migration : gz-msgs #262

merged 2 commits into from
Jun 21, 2022

Conversation

methylDragon
Copy link
Contributor

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 12, 2022
@methylDragon methylDragon mentioned this pull request Jun 12, 2022
Closed
18 tasks
@codecov
Copy link

codecov bot commented Jun 13, 2022 •
edited
Loading

Codecov Report

Merging #262 (bb57e17) into main (f82e2e5) will decrease coverage by 0.14%.
The diff coverage is n/a.

❗ Current head bb57e17 differs from pull request most recent head 667f93a. Consider uploading reports for the commit 667f93a to get more accurate results

@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
- Coverage   14.53%   14.38%   -0.15%     
==========================================
  Files         200      200              
  Lines       12505    12505              
==========================================
- Hits         1817     1799      -18     
- Misses      10688    10706      +18
Impacted Files Coverage Δ
src/gz.cc 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f82e2e5...667f93a. Read the comment docs.

@methylDragon methylDragon marked this pull request as ready for review June 13, 2022 05:37
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 13, 2022
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Jun 15, 2022
chapulina
chapulina reviewed Jun 15, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to remember to rebase-merge this, because there are files being moved.

src/CMakeLists.txt Outdated Show resolved Hide resolved
@methylDragon methylDragon force-pushed the cli_migration branch 2 times, most recently from de1d2ac to c5f3770 Compare June 16, 2022 21:29
@methylDragon
Move CLI files
e5e1067 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate CLI
667f93a 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Jun 21, 2022
@chapulina
Copy link
Contributor

@osrf-jenkins run tests again please, now UNIT_gz_TEST should be built

@chapulina chapulina mentioned this pull request Jun 21, 2022
Merged
9 tasks
chapulina
chapulina approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UNIT_gz_TEST building and passing on Linux and macOS 🚀

@chapulina chapulina merged commit 373d333 into main Jun 21, 2022
@chapulina chapulina deleted the cli_migration branch June 21, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina