Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .dll installation directory on Windows #74

Merged
merged 3 commits into from
Dec 20, 2021

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Nov 29, 2021

🦟 Bug fix

Fix .dll installation directory on Windows .

Summary

On Windows, .dll libraries are tipically installed in <prefix>/bin, while before this fix, the .dll libraries were installed by this project in <prefix>/lib, resulting the warning:

Library error: ignition-tools-backward.dll not found. Improved backtrace generation will be disabled

When the ign command was used, as ignition-tools-backward.dll was not found in the directory in which ruby's function to find dll libraries was looking into.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added 🌱 garden Ignition Garden 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Nov 29, 2021
Signed-off-by: Silvio <silvio@traversaro.it>
install (TARGETS backward
LIBRARY DESTINATION ${LIB_INSTALL_DIR}
ARCHIVE DESTINATION ${LIB_INSTALL_DIR}
RUNTIME DESTINATION ${BIN_INSTALL_DIR})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j-rivero , do you foresee any problems on Linux or macOS?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to documentation:

RUNTIME

    Target artifacts of this kind include:

        Executables (except on macOS when marked as MACOSX_BUNDLE, see BUNDLE below);
        DLLs (on all Windows-based systems including Cygwin; note that the accompanying import libraries are of kind ARCHIVE).

Should affect only DLLs on Windows being backward a library. I don't see problems here.

@j-rivero j-rivero self-requested a review December 20, 2021 20:13
@j-rivero j-rivero merged commit f87f7b9 into gazebosim:ign-tools1 Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants