Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix .dll installation directory on Windows #74

Merged
merged 3 commits into from
Dec 20, 2021
Merged

Fix .dll installation directory on Windows #74

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d332026
Fix .dll installation directory on Windows
traversaro Nov 29, 2021
59a32cd
Merge branch 'ign-tools1' into patch-4
caguero Nov 29, 2021
81f0464
Merge branch 'ign-tools1' into patch-4
chapulina Dec 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ if(MSVC)
target_compile_options(backward PUBLIC /wd4267)
target_compile_options(backward PUBLIC /wd4996)
endif()
install (TARGETS backward DESTINATION ${LIB_INSTALL_DIR})
install (TARGETS backward
LIBRARY DESTINATION ${LIB_INSTALL_DIR}
ARCHIVE DESTINATION ${LIB_INSTALL_DIR}
RUNTIME DESTINATION ${BIN_INSTALL_DIR})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j-rivero , do you foresee any problems on Linux or macOS?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to documentation:

RUNTIME

    Target artifacts of this kind include:

        Executables (except on macOS when marked as MACOSX_BUNDLE, see BUNDLE below);
        DLLs (on all Windows-based systems including Cygwin; note that the accompanying import libraries are of kind ARCHIVE).

Should affect only DLLs on Windows being backward a library. I don't see problems here.


#===============================================================================
# Used for the installed version.
Expand Down