Merge 3 -> main #152
Merged
Merge 3 -> main #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
* No EOL, no flush, no register in Loggers Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
The severity level of the file sink is now set to trace so that it logs to file regardless of the severity level of the console. This patch also adds an API to set the severity level of just the console sink. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
The logger level change is needed because the file sink's level is `trace` and apparently `spdlog` will use the lower severity level of the logger and the sink. The `flush_on` change is needed to cause spdlog to write to file more frequently. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Prepare for 3.0.0 Release
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
* Make the log example show file source location --------- Signed-off-by: Carlos Agüero <caguero@openrobotics.org> Signed-off-by: Ian Chen <ichen@openrobotics.org> Co-authored-by: Ian Chen <ichen@openrobotics.org>
caguero
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port gz-utils3 to main
Branch comparison: main...gz-utils3
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)