-
Notifications
You must be signed in to change notification settings - Fork 93
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix GSG violations on non-trivially destructible types (#1264)
* Types.hh, kSdfScopeDelimiter Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * use constexpr char for preferred_separator Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * parser_urdf, constexpr instead of const Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * ParticleEmitter, kEmitterTypeStrs Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Camera, kPixelFormatNames Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Sensor, kSensorTypeStrs Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Types, kSdfScopeDelimiter, use string_view instead of char array Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Revert changes to parser_urdf.cc Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Added comment about size template parameter Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Reverting mistake on double back slashes, and keeping static const char Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Using NeverDestroyed for kSdfScopeDelimiter Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Revert use of string_view for Sensor and Camera as macOS doesn't treat them as literals Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Reverting to static const to hopefully appease win and macos Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Fix implicit instantiate Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Using const string_view this time Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Suggestions for deprecating kSdfScopeDelimiter (#1265) Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> --------- Signed-off-by: Aaron Chong <aaronchongth@gmail.com> Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
- Loading branch information
1 parent
8a26cb4
commit e98fcd8
Showing
9 changed files
with
65 additions
and
35 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters