Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the deprecated kSdfScopeDelimiter still works #1305

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Jul 28, 2023

🦟 Bug fix

Summary

The deprecated kSdfScopeDelimiter was initialized to an empty string instead of ::. This PR makes sure kSdfScopeDelimiter and kScopeDelimiter represent the same string.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from scpeters as a code owner July 28, 2023 21:55
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #1305 (afc4b80) into main (9fc8150) will not change coverage.
The diff coverage is 100.00%.

❗ Current head afc4b80 differs from pull request most recent head 44226e1. Consider uploading reports for the commit 44226e1 to get more accurate results

@@           Coverage Diff           @@
##             main    #1305   +/-   ##
=======================================
  Coverage   87.60%   87.60%           
=======================================
  Files         128      128           
  Lines       16830    16830           
=======================================
  Hits        14744    14744           
  Misses       2086     2086           
Files Changed Coverage Δ
src/Types.cc 100.00% <100.00%> (ø)

@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 31, 2023
@azeey azeey merged commit 57511b8 into gazebosim:main Aug 1, 2023
5 checks passed
@azeey azeey deleted the fix_ksdfscopedelimiter branch August 1, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants