Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Param_TEST: Check return values of Param::Get/Set #1394

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Apr 5, 2024

🦟 Bug fix

Adds more expectations to a unit test

Summary

While investigating how to implement a suggestion added in a comment in d353294, I noticed that the UNIT_Param_TEST has many calls to bool Param::Get and bool Param::Set without checking the return value. This adds expectations on the return value of those function calls, which will aid in addressing the aforementioned comment with a behavior change PR on main.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from azeey as a code owner April 5, 2024 23:20
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.42%. Comparing base (ff9b3ad) to head (e960bed).
Report is 5 commits behind head on sdf14.

Additional details and impacted files
@@           Coverage Diff           @@
##            sdf14    #1394   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files         134      134           
  Lines       17751    17751           
=======================================
  Hits        16406    16406           
  Misses       1345     1345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahcorde ahcorde merged commit 939786f into sdf14 Apr 8, 2024
13 checks passed
@ahcorde ahcorde deleted the scpeters/param_get_set_test branch April 8, 2024 07:46
aagrawal05 pushed a commit to aagrawal05/sdformat that referenced this pull request Aug 16, 2024
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
aagrawal05 pushed a commit to aagrawal05/sdformat that referenced this pull request Aug 16, 2024
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants