Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cone as a primitive parametric shape. #1415

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Conversation

bperseghetti
Copy link
Member

@bperseghetti bperseghetti commented May 13, 2024

🦟 Bug fix

Summary

This helps add the missing cone geometry for primitive/basic parametric shapes:

conetopple
cone

And is also valuable for visualizations of emitters/source that typically have conic-based spread as seen in this acoustic attack on an IMU by showing the affected area:

drone_attack

Associated PRs:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label May 13, 2024
include/sdf/Cone.hh Outdated Show resolved Hide resolved
src/Cone.cc Outdated Show resolved Hide resolved
test/sdf/basic_shapes.sdf Outdated Show resolved Hide resolved
test/sdf/shapes.sdf Outdated Show resolved Hide resolved
test/sdf/shapes_world.sdf Outdated Show resolved Hide resolved
bperseghetti and others added 2 commits June 19, 2024 03:00
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Co-authored-by: Steve Peters <computersthatmove@gmail.com>
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
@caguero caguero merged commit 7f119b4 into gazebosim:sdf14 Jun 20, 2024
10 checks passed
@bperseghetti bperseghetti deleted the pr-cone branch June 21, 2024 01:20
aagrawal05 pushed a commit to aagrawal05/sdformat that referenced this pull request Aug 16, 2024
* Backport:  Add cone shape to SDFormat spec (gazebosim#1418)

Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Co-authored-by: Steve Peters <computersthatmove@gmail.com>
aagrawal05 pushed a commit to aagrawal05/sdformat that referenced this pull request Aug 16, 2024
* Backport:  Add cone shape to SDFormat spec (gazebosim#1418)

Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Co-authored-by: Steve Peters <computersthatmove@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants