Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bm/dbt-precompiled-model-hash #26

Merged
merged 3 commits into from
May 14, 2024

Conversation

bmoore813
Copy link
Contributor

This will allow tagging to automatically have a tag that uses the hash of the precompiled dbt model so they can better measure the delta in cost when a change is made to a model

@bmoore813 bmoore813 had a problem deploying to Approve Integration Tests May 3, 2024 01:34 — with GitHub Actions Failure
@bmoore813 bmoore813 had a problem deploying to Approve Integration Tests May 3, 2024 01:46 — with GitHub Actions Failure
{%- do comment_dict.update({
"dbt_raw_code_hash": local_md5(node.raw_code)
}) -%}
{%- endif -%}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmoore813 just curious, does raw_code refer to the raw SQL with the jinja references + model config block at the top?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the question and happy to test further but it was my understanding that depending on the node in jinja it could be an option of these so if it exists then it pulls from the graph and applies what the raw_code is....How do you think I could better test to ensure this is the raw dbt code that is in question

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but yes I would assume this is what the code looks like on the repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just looked at what the raw_code looks like in the manifest.json and it is indeed exactly as I just suggested.

@NiallRees NiallRees had a problem deploying to Approve Integration Tests May 14, 2024 09:06 — with GitHub Actions Failure
@NiallRees NiallRees merged commit 8d30ce0 into get-select:main May 14, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants