Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bm/dbt-precompiled-model-hash #26

Merged
merged 3 commits into from
May 14, 2024
Merged

bm/dbt-precompiled-model-hash #26

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d8fee4
bm/dbt-precompiled-model-hash
bmoore813 May 3, 2024
2ee6270
remove comment
bmoore813 May 3, 2024
a3137b7
Remove dbt prefix
NiallRees May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions macros/query_comment.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,36 +53,42 @@
materialized=node.config.materialized,
) -%}
{%- endif -%}

{%- if node.raw_code is not none -%}
{%- do comment_dict.update({
"raw_code_hash": local_md5(node.raw_code)
}) -%}
{%- endif -%}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmoore813 just curious, does raw_code refer to the raw SQL with the jinja references + model config block at the top?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the question and happy to test further but it was my understanding that depending on the node in jinja it could be an option of these so if it exists then it pulls from the graph and applies what the raw_code is....How do you think I could better test to ensure this is the raw dbt code that is in question

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but yes I would assume this is what the code looks like on the repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just looked at what the raw_code looks like in the manifest.json and it is indeed exactly as I just suggested.

{%- endif -%}

{%- if env_var('DBT_CLOUD_PROJECT_ID', False) -%}
{%- do comment_dict.update(
dbt_cloud_project_id=env_var('DBT_CLOUD_PROJECT_ID')
) -%}
{%- do comment_dict.update(
dbt_cloud_project_id=env_var('DBT_CLOUD_PROJECT_ID')
) -%}
{%- endif -%}

{%- if env_var('DBT_CLOUD_JOB_ID', False) -%}
{%- do comment_dict.update(
dbt_cloud_job_id=env_var('DBT_CLOUD_JOB_ID')
) -%}
{%- do comment_dict.update(
dbt_cloud_job_id=env_var('DBT_CLOUD_JOB_ID')
) -%}
{%- endif -%}

{%- if env_var('DBT_CLOUD_RUN_ID', False) -%}
{%- do comment_dict.update(
dbt_cloud_run_id=env_var('DBT_CLOUD_RUN_ID')
) -%}
{%- do comment_dict.update(
dbt_cloud_run_id=env_var('DBT_CLOUD_RUN_ID')
) -%}
{%- endif -%}

{%- if env_var('DBT_CLOUD_RUN_REASON_CATEGORY', False) -%}
{%- do comment_dict.update(
dbt_cloud_run_reason_category=env_var('DBT_CLOUD_RUN_REASON_CATEGORY')
) -%}
{%- do comment_dict.update(
dbt_cloud_run_reason_category=env_var('DBT_CLOUD_RUN_REASON_CATEGORY')
) -%}
{%- endif -%}

{%- if env_var('DBT_CLOUD_RUN_REASON', False) -%}
{%- do comment_dict.update(
dbt_cloud_run_reason=env_var('DBT_CLOUD_RUN_REASON')
) -%}
{%- do comment_dict.update(
dbt_cloud_run_reason=env_var('DBT_CLOUD_RUN_REASON')
) -%}
{%- endif -%}

{{ return(tojson(comment_dict)) }}
Expand Down
Loading