Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mypy issue #674

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

beliaev-maksim
Copy link
Collaborator

@beliaev-maksim beliaev-maksim commented Sep 22, 2023

Currently mypy is raising an error on master branch

responses/__init__.py:1051:32: error: Incompatible types in assignment (expression has type "PreparedRequest", variable has type "Request | None")  [assignment]

I do not know why mypy thinks that it could be None

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
responses/__init__.py 100.00%

📢 Thoughts on this report? Let us know!.

@markstory markstory merged commit a7d76ce into getsentry:master Sep 25, 2023
16 checks passed
@beliaev-maksim beliaev-maksim deleted the mbeliaev/fix_mypy branch September 25, 2023 15:45
beliaev-maksim added a commit to beliaev-maksim/responses that referenced this pull request Sep 25, 2023
markstory pushed a commit that referenced this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants