Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix mypy issue" #676

Merged

Conversation

beliaev-maksim
Copy link
Collaborator

Reverts #674

I do not know why, but now it started to work back and CI fails on master (facepalm)

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
responses/__init__.py 100.00%

📢 Thoughts on this report? Let us know!.

@beliaev-maksim
Copy link
Collaborator Author

what a miracle, both CIs have the same packages installed, how can it be different

@markstory ideas?

@markstory
Copy link
Member

ideas?

Nope, this is spooky mypy behavior to me too.

@markstory markstory merged commit cf05e41 into getsentry:master Sep 25, 2023
16 checks passed
@beliaev-maksim beliaev-maksim deleted the revert-674-mbeliaev/fix_mypy branch September 25, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants