Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opentelemetry http server responses not rendered with correct span description #11755

Closed
3 tasks done
AbhiPrasad opened this issue Apr 23, 2024 · 0 comments · Fixed by #11756
Closed
3 tasks done

Opentelemetry http server responses not rendered with correct span description #11755

AbhiPrasad opened this issue Apr 23, 2024 · 0 comments · Fixed by #11756
Labels
Package: node Issues related to the Sentry Node SDK Package-Meta: OpenTelemetry Type: Bug

Comments

@AbhiPrasad
Copy link
Member

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/node

SDK Version

8.0.0-beta.3

Framework Version

No response

Link to Sentry event

No response

SDK Setup

No response

Steps to Reproduce

https://discord.com/channels/621778831602221064/1232055515782320199/1232055515782320199

Expected Result

http.server op, http.route as span name

We need to update our parsing code to use http.request.method

sentry-javascript/packages/opentelemetry/src/utils/parseSpanDescription.ts

Line 38 in bee0677

const httpMethod = attributes[SEMATTRS_HTTP_METHOD];

This needs to be upstreamed into OTEL first - they are not exposed from the semantic conventions.

Actual Result

image
@github-actions github-actions bot added the Package: node Issues related to the Sentry Node SDK label Apr 23, 2024
This was referenced Apr 23, 2024
Open
Merged
AbhiPrasad added a commit that referenced this issue Apr 24, 2024
@AbhiPrasad
feat(opentelemetry): Support new http method attribute (#11756)
57d6045 
Fixes #11755

OpenTelemetry restructured their http semantic conventions and declared
them stable:
https://opentelemetry.io/blog/2023/http-conventions-declared-stable/

This has unfortunately not been reflected in OpenTelemetry JS yet,
blocked on them making everything backwards compat:
open-telemetry/opentelemetry-js#4572

For now we can directly reference `http.request.method`, the replacement
to `http.method`. When the OTEL SDK is finally updated to use proper
conventions, we can avoid hard coding the string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Package: node Issues related to the Sentry Node SDK Package-Meta: OpenTelemetry Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(opentelemetry): Support new http method attribute getsentry/sentry-javascript
1 participant
@AbhiPrasad