Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic stack trace being printed during recovery of broken pipe (#1089) #1259

Merged
merged 40 commits into from
Nov 6, 2018

Commits on Feb 27, 2018

  1. Configuration menu
    Copy the full SHA
    80916dc View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2018

  1. Add test for recovery of broken pipe (gin-gonic#1089)

    Justin Israel authored and justinfx committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    133a62d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d3bcb45 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2018

  1. Configuration menu
    Copy the full SHA
    e7078e9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    97c4c98 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d3a05e4 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2018

  1. chore: add a version file includes gin version (gin-gonic#1549)

    * chore: add a version file includes gin version
    
    * update version for dev version
    thinkerou authored and justinfx committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    076e182 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    10ba502 View commit details
    Browse the repository at this point in the history
  3. chore: recover go master build, partial revert gin-gonic#1514 (gin-go…

    …nic#1561)
    
    * chore: recover go master build, partial revert gin-gonic#1514
    
    * chore: add master to go branch build targets
    javierprovecho authored and justinfx committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    8a7ccc3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    500ad23 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d02ae1e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1e326a1 View commit details
    Browse the repository at this point in the history
  7. Don't log requests (gin-gonic#1370)

    Fixes gin-gonic#1331
    
    HTTP logging leaks sensitive request information.
    
    This PR removes HTTP request logging during panics.
    dustin-decker authored and justinfx committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    5548cc3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    946eba9 View commit details
    Browse the repository at this point in the history
  9. Make logger use a yellow background and a darkgray text for legibility (

    gin-gonic#1570)
    
    1. Why is this change neccesary?
    White text on a yellow background was illegible with most terminal color schemes
    
    2. How does it address the issue?
    The white text was replaced with a bash compatible dark gray while keeping the
    yellow background colour
    
    3. What side effects does this change have?
    Resolves gin-gonic#1552
    andrea authored and justinfx committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    425f80b View commit details
    Browse the repository at this point in the history
  10. feat: add go version judge when print debug warning log (gin-gonic#1572)

    * feat: add go version judge when print debug warning log
    
    * remove invalid statement
    
    * use one const
    thinkerou authored and justinfx committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    d1b243d View commit details
    Browse the repository at this point in the history
  11. fix: fmt output log to os.Stderr (gin-gonic#1571)

    fix gin-gonic#1560 changes are breaking in App Engine.
    
    cc @giulianobr @philippgille
    appleboy authored and justinfx committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    331ad88 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    1ded27a View commit details
    Browse the repository at this point in the history
  13. remove allow fail flag (gin-gonic#1573)

    golang team revert the net/url issue: golang/go#27302
    appleboy authored and justinfx committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    e4e4270 View commit details
    Browse the repository at this point in the history
  14. removed use of sync.pool from HandleContext and added test coverage (g…

    …in-gonic#1565)
    
    As per gin-gonic#1230 there is an issue when using HandleContext where the context of the request is returned to the context sync.Pool before the parent request has finished, causing context to be used in a non-thread safe manner.
    
    I've removed the bug by not entering the context back in the pool and leaving that to ServeHTTP.
    
    There was no test coverage for this function so I've also added the test to cover it. As the bug only happens when there are concurrent requests, the tests issues hundreds of concurrent requests. Without the bug fixed the tests do consistently recreate the error.
    japettyjohn authored and justinfx committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    5cc05e9 View commit details
    Browse the repository at this point in the history
  15. Update README.md (gin-gonic#1583)

    change "hava" to "have"
    zesani authored and justinfx committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    9a0fc0f View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    bf40076 View commit details
    Browse the repository at this point in the history
  17. fix(Makefile): golint to new URL (gin-gonic#1592)

    as title. Just update the golint to new URL.
    appleboy authored and justinfx committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    cd693b4 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    2bcc84a View commit details
    Browse the repository at this point in the history
  19. attempt to support go module (gin-gonic#1569)

    * support go module
    
    * update golint package url
    
    * update golint
    thinkerou authored and justinfx committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    e3a3b89 View commit details
    Browse the repository at this point in the history
  20. document: add docs dir and middleware document (gin-gonic#1521)

    * init docs dir
    
    * add middleware document
    
    * fix indent
    
    * update docs
    thinkerou authored and justinfx committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    d369746 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    37c19a7 View commit details
    Browse the repository at this point in the history
  22. Fix LoadHTML* tests (gin-gonic#1559)

    Digging into the test code base I've found out that some of the tests for `LoadHTML*` methods are not reliable and efficient. They use timeouts to be sure that goroutine with the server has started. And even more, in old implementation, the server started only once – all the new instances silently failed due to the occupied network port.
    
    Here is a short overview of the proposed changes: 
    - it's not necessary to rely on timeouts, the server starts listening synchronously and returns control when it is ready
    - once the server is run, it's stopped after a test passes
    - dry out http server setup
    - magic with empty closure return is eliminated 
    - preserve router.RunTLS coverage with integration tests
    sponomarev authored and justinfx committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    a5395d5 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    de4743e View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    64ea6f1 View commit details
    Browse the repository at this point in the history
  25. Pass MaxMultipartMemory when FormFile is called (gin-gonic#1600)

    When `gin.Context.FormFile("...")` is called the `engine.MaxMultipartMemory` is never used. This PR makes sure that the `MaxMultipartMemory` is passed and removes 2 calls to `http.Request.ParseForm` since they are called from `http.Request.ParseMultipartForm`
    Ismail Gjevori authored and justinfx committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    940d1f5 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    c03447e View commit details
    Browse the repository at this point in the history
  27. FIX r.LoadHTMLGlob("/path/to/templates") (gin-gonic#1616)

    FIX r.LoadHTMLGlob("/path/to/templates")) to r.LoadHTMLGlob("/path/to/templates")
    forging2012 authored and justinfx committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    4940983 View commit details
    Browse the repository at this point in the history
  28. Added some comments to avoid having golint warnings (gin-gonic#1619)

    The following comments to vars, conts and method were added to pass  `golinter` with 100%.
    
    ![captura de pantalla 2018-10-31 a la s 15 23 37](https://user-images.githubusercontent.com/10160626/47819725-faba3780-dd20-11e8-978c-1b3ab7de26ed.png)
    root@andrea:~# authored and justinfx committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    58e2fbc View commit details
    Browse the repository at this point in the history
  29. Change HTML input tags to use HTML5 syntax. (gin-gonic#1617)

    In XHTML, the <input> tag must be properly closed, like this `<input />`.  In HTML5 the `<input>` tag has no ending slash.  https://www.w3schools.com/tags/tag_input.asp
    jbampton authored and justinfx committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    6c0566e View commit details
    Browse the repository at this point in the history
  30. Change HTML link tags to use HTML5 syntax. (gin-gonic#1621)

    The `<link>` element is an empty element, it contains attributes only. In HTML5 the `<link>` tag has no end tag. In XHTML the `<link>` tag must be properly closed.
    jbampton authored and justinfx committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    7f6ddf2 View commit details
    Browse the repository at this point in the history
  31. Update README.md (gin-gonic#1620)

    Missing the right colon
    chenyang929 authored and justinfx committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    17b319b View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    a3804b6 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    92abfec View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2018

  1. Configuration menu
    Copy the full SHA
    9cbf651 View commit details
    Browse the repository at this point in the history