Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VS Code] VS Code always defaults to Light theme #2497

Closed
sr229 opened this issue Dec 10, 2020 · 3 comments · Fixed by #3490
Closed

[VS Code] VS Code always defaults to Light theme #2497

sr229 opened this issue Dec 10, 2020 · 3 comments · Fixed by #3490
Labels
editor: code (browser) meta: never-stale This issue can never become stale priority: 💪 stretch goal This issue is a stretch goal within an iteration. type: feature request New feature or request

Comments

@sr229
Copy link

sr229 commented Dec 10, 2020

Describe the bug

Theia by default in Gitpod's configuration is defaulted in dark mode. Visual Studio Code however in my instance does not, as it defaults to light theme almost immediately.

Steps to reproduce

Reproducible by just creating any workspace in GitHub by selecting VS Code as your default editor.

Video Evidence provided here.
@gtsiolis gtsiolis mentioned this issue Dec 14, 2020
Closed
@akosyakov akosyakov added this to the February 2021 milestone Feb 1, 2021
@akosyakov akosyakov added the priority: 💪 stretch goal This issue is a stretch goal within an iteration. label Feb 1, 2021
@akosyakov
Copy link
Member

probably will be resolved by #2707

@sr229
Copy link
Author

sr229 commented Feb 27, 2021

probably will be resolved by #2707

is there a working staging build of this, would be neat to try it out before it goes live.

@akosyakov
Copy link
Member

It happens only once for a user for very first workspace with #2707.

@akosyakov akosyakov modified the milestones: February 2021, March 2021 Mar 1, 2021
@csweichel csweichel modified the milestones: [backlog] March 2021, [do-not-add-issues] March 2021 Mar 1, 2021
@csweichel csweichel added the meta: never-stale This issue can never become stale label Mar 17, 2021
akosyakov added a commit that referenced this issue Mar 18, 2021
@akosyakov
[vscode] fix #2497: fix default theme
400f4e1
@akosyakov akosyakov mentioned this issue Mar 18, 2021
Merged
akosyakov added a commit that referenced this issue Mar 19, 2021
@akosyakov
[vscode] fix #2497: fix default theme
db60d35
akosyakov added a commit that referenced this issue Mar 19, 2021
@akosyakov
[vscode] fix #2497: fix default theme
a081891
pavan-tri pushed a commit to trilogy-group/gitpod that referenced this issue Apr 28, 2021
@akosyakov
[vscode] fix gitpod-io#2497: fix default theme
8d3fb1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editor: code (browser) meta: never-stale This issue can never become stale priority: 💪 stretch goal This issue is a stretch goal within an iteration. type: feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[vscode] fix default theme gitpod-io/gitpod
3 participants
@akosyakov @csweichel @sr229