Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] fix default theme #3490

Merged
merged 1 commit into from
Mar 19, 2021
Merged

[vscode] fix default theme #3490

merged 1 commit into from
Mar 19, 2021

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Mar 18, 2021 •
edited
Loading

What it does

Changes in VS Code: gitpod-io/openvscode-server#7

How to test

  • Switch to Code, start a new worksapce you should see dark theme without flickering.
  • Change theme, start another workspace and check that theme is preserved without flickering as well.

@akosyakov akosyakov marked this pull request as draft March 18, 2021 15:17
@akosyakov akosyakov marked this pull request as ready for review March 18, 2021 15:36
svenefftinge
svenefftinge approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well

gtsiolis
gtsiolis approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akosyakov! Works like a charm! 🔮

sr229
sr229 approved these changes Mar 18, 2021
View reviewed changes
Copy link

@sr229 sr229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified works over in a local instance

@akosyakov akosyakov force-pushed the akosyakov/vs-code-vs-code-always-2497 branch from 400f4e1 to db60d35 Compare March 19, 2021 07:06
@akosyakov akosyakov merged commit a081891 into main Mar 19, 2021
@akosyakov akosyakov deleted the akosyakov/vs-code-vs-code-always-2497 branch March 19, 2021 07:45
@sr229
Copy link

sr229 commented Mar 19, 2021 •
edited by werft-gitpod-dev-com bot
Loading

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtsiolis gtsiolis gtsiolis approved these changes

@svenefftinge svenefftinge svenefftinge approved these changes

@sr229 sr229 sr229 approved these changes

Assignees
No one assigned
Labels
component: ide editor: code (browser) user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[VS Code] VS Code always defaults to Light theme
4 participants
@akosyakov @sr229 @gtsiolis @svenefftinge