-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kots] remove cert-manager from Gitpod package #8785
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8785 +/- ##
=======================================
Coverage 11.17% 11.17%
=======================================
Files 18 18
Lines 993 993
=======================================
Hits 111 111
Misses 880 880
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start, but a couple of thoughts on it
a630840
to
c139f27
Compare
d0049ef
to
137091a
Compare
Updated the PR to not mention the pre-requisite requirement of Will raise a PR once we take a decision there. We can review and merge this removal meanwhile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
This is good work @Pothulapati. I'd like to get the work in to remove the (cluster)issuer setup as well which is why I've put this on hold - if you want me to do it, remove the hold and we'll merge yours in. If you want to add it to this PR, please do so and I'll add that to the review.
Currently, We include `cert-manager` instance into the Gitpod kots package, and install it whenever Gitpod installation is requested. This causes the following problems: - `cert-manager` is a separate beast on its own, There are numerous configurations that might be needed to be set to make it run correctly. - A lot users could have already have it installed, and have to struggle to get Gitpod up and running in those cases. To solve them, We could either provide all the configurations of `cert-manager` into the Gitpod package to cater users with all config needs or remove the package and expect `cert-manager` as a pre-requisite and make sure its documented. The latter feels better as it removes the maintaince of cert-manager for us while also allowing users to have specific configuration. The install path for `cert-manager` is [also pretty well documented](https://cert-manager.io/docs/installation/) with all the [changes needed based on the cluster environment](https://cert-manager.io/docs/installation/compatibility/). This PR also removes the cert-manager issuers and updates the config to allow users to use pre-configured resources Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
7bc9e11
to
c904a6a
Compare
@mrsimonemms I've updated the commit log to include a single commit for both this and the other PR that got merged into this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/unhold |
With #8785, We expect users to install their own `cert-manager` install. This PR adds a new pre-flight check to verify the existence of the `cert-manager`. As there is no general way to check for the existence of `cert-manager`, We check for the `certificates.cert-manager.io` CRD instead. Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
With #8785, We expect users to install their own `cert-manager` install. This PR adds a new pre-flight check to verify the existence of the `cert-manager`. As there is no general way to check for the existence of `cert-manager`, We check for the `certificates.cert-manager.io` CRD instead. Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
With #8785, We expect users to install their own `cert-manager` install. This PR adds a new pre-flight check to verify the existence of the `cert-manager`. As there is no general way to check for the existence of `cert-manager`, We check for the `certificates.cert-manager.io` CRD instead. Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
Description
Currently, We include
cert-manager
instance into theGitpod
kots
package, and install it whenever Gitpod installationis requested.
This causes the following problems:
cert-manager
is a separate beast on its own, There are numerousconfigurations that might be needed to be set to make it run correctly
based on the cluster config.
struggle to get Gitpod up and running in those cases.
To solve them, We could either provide all the configurations of
cert-manager
into the Gitpod package to cater users with allconfig needs or remove the package and expect
cert-manager
as apre-requisite and make sure its documented.
The latter feels better as it removes the maintenance of cert-manager for
us while also allowing users to have specific configuration. The install
path for
cert-manager
is also pretty well documentedwith all the changes needed based on the cluster environment.
This PR also removes the cert-manager issuers and updates the config to allow
users to use pre-configured resources
Signed-off-by: Tarun Pothulapati tarun@gitpod.io
Related Issue(s)
Fixes #8749
How to test
Gitpod
usingk kots install gitpod-pov/dev-tar
Release Notes
Documentation