Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kots] remove cert-manager from Gitpod package #8785

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Commits on Mar 16, 2022

  1. [kots] remove cert-manager from Gitpod package

    Currently, We include `cert-manager` instance into the
    Gitpod kots package, and install it whenever Gitpod installation
    is requested.
    
    This causes the following problems:
    
    - `cert-manager` is a separate beast on its own, There are numerous
    configurations that might be needed to be set to make it run correctly.
    - A lot users could have already have it installed, and have to
      struggle to get Gitpod up and running in those cases.
    
    To solve them, We could either provide all the configurations of
    `cert-manager` into the Gitpod package to cater users with all
    config needs or remove the package and expect `cert-manager` as a
    pre-requisite and make sure its documented.
    
    The latter feels better as it removes the maintaince of cert-manager for
    us while also allowing users to have specific configuration. The install
    path for `cert-manager` is [also pretty well documented](https://cert-manager.io/docs/installation/)
    with all the [changes needed based on the cluster environment](https://cert-manager.io/docs/installation/compatibility/).
    
    This PR also removes the cert-manager issuers and updates the config to allow
    users to use pre-configured resources
    
    Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
    Pothulapati committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    c904a6a View commit details
    Browse the repository at this point in the history