Fix cancel button in the page of project edit not work (#23655) #23813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, in project edit page, the cancel button is not work. https://user-images.githubusercontent.com/33891828/227182731-6478e29f-0e52-48c4-beb0-6a7d1dda6a1d.mov 1. The wrong classname `cancel` was added to the `<a>` tag. That classname caused the default click event of `<a>` tag to be cancelled. Because we have the following settings in the global. So I remove the classname `cancel`. https://github.com/go-gitea/gitea/blob/9be90a58754061171bbd5025d85d2b891364efd3/web_src/js/features/common-global.js#L325-L327 2. Another change is that page will redirect to the previous page. https://user-images.githubusercontent.com/33891828/227187326-c653c6d6-9715-440f-a732-ba0a6f012c81.mov # Conflicts: # templates/projects/new.tmpl # templates/repo/projects/new.tmpl # web_src/js/features/common-global.js
lunny
approved these changes
Mar 30, 2023
GiteaBot
added
the
lgtm/need 1
delvh
approved these changes
Mar 30, 2023
GiteaBot
added
lgtm/done
delvh
added
the
reviewed/wait-merge
KN4CK3R
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #23655
Before, in project edit page, the cancel button is not work.
Screen.Recording.2023-03-23.at.17.55.08.mov
cancelwas added to the<a>tag. That classname caused the default click event of<a>tag to be cancelled. Because we have the following settings in the global. So I remove the classnamecancel.gitea/web_src/js/features/common-global.js
Lines 325 to 327 in 9be90a5
Screen.Recording.2023-03-23.at.19.15.23.mov