Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cancel button in the page of project edit not work (#23655) #23813

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Fix cancel button in the page of project edit not work (#23655) #23813

merged 2 commits into from
Mar 30, 2023

Commits on Mar 30, 2023

  1. Fix cancel button in the page of project edit not work (go-gitea#23655) 

    Before, in project edit page, the cancel button is not work.

https://user-images.githubusercontent.com/33891828/227182731-6478e29f-0e52-48c4-beb0-6a7d1dda6a1d.mov

1. The wrong classname `cancel` was added to the `<a>` tag. That
classname caused the default click event of `<a>` tag to be cancelled.
Because we have the following settings in the global. So I remove the
classname `cancel`.

https://github.com/go-gitea/gitea/blob/9be90a58754061171bbd5025d85d2b891364efd3/web_src/js/features/common-global.js#L325-L327

2. Another change is that page will redirect to the previous page.

https://user-images.githubusercontent.com/33891828/227187326-c653c6d6-9715-440f-a732-ba0a6f012c81.mov
# Conflicts:
#	templates/projects/new.tmpl
#	templates/repo/projects/new.tmpl
#	web_src/js/features/common-global.js
    @sillyguodong
    sillyguodong committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    62a46e4 View commit details
    Browse the repository at this point in the history

  2. revert

    @sillyguodong
    sillyguodong committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    74b4909 View commit details
    Browse the repository at this point in the history