Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show usernames in reaction tooltips #26444

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

n0toose
Copy link
Contributor

@n0toose n0toose commented Aug 10, 2023

Even if GetDisplayName() is normally preferred elsewhere, this change
provides more consistency, as usernames are also always being shown
when participating in a conversation taking place in an issue or
a pull request. This change makes conversations easier to follow, as
you would not have to have a mental association between someone's
username and someone's real name in order to follow what is happening.

This behavior matches GitHub's. Optimally, both the username and the
full name (if applicable) could be shown, but such an effort is a
much bigger task that needs to be thought out well.

Even if GetDisplayName() is normally preferred elsewhere, this change
provides more consistency, as usernames are also always being shown
when participating in a conversation taking place in an issue or a
pull request. This change makes conversations easier to follow, as
you would not have to have a mental association between someone's
username and someone's real name in order to follow what is happening.

This behavior matches GitHub's. Optimally, both the username and the
full name (if applicable) could be shown, but such an effort is a
much bigger task that needs to be thought out well.
@n0toose
Copy link
Contributor Author

n0toose commented Aug 10, 2023

Screenshot:

image

I may have forgotten to update a test, I'll push another commit soon if that's the case.

EDIT: Nope, passes locally.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 10, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 10, 2023
@silverwind
Copy link
Member

Shouldn't pass locally :)

--- FAIL: TestIssueReactionCount (0.03s)
    reaction_test.go:112: 
        	Error Trace:	/home/runner/work/gitea/gitea/models/issues/reaction_test.go:112
        	Error:      	Not equal: 
        	            	expected: "User One, < U<se>r Tw<o > ><"
        	            	actual  : "user1, user2"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-User One, < U<se>r Tw<o > ><
        	            	+user1, user2
        	Test:       	TestIssueReactionCount

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 10, 2023
@n0toose
Copy link
Contributor Author

n0toose commented Aug 10, 2023

Shouldn't pass locally :)

That's because I did make test-sqlite! THAT was a pitfall, a mistake on my end makes much more sense.

@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 10, 2023
@silverwind silverwind enabled auto-merge (squash) August 10, 2023 20:49
@silverwind silverwind merged commit 2cbd377 into go-gitea:main Aug 10, 2023
23 checks passed
@GiteaBot GiteaBot added this to the 1.21.0 milestone Aug 10, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 10, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 11, 2023
* upstream/main:
  Update upgrade documentation to add a check for deprecated configurations (go-gitea#26451)
  Fall back to esbuild for css minify (go-gitea#26445)
  Update JS dependencies (go-gitea#26449)
  Call git.InitSimple for runRepoSyncReleases (go-gitea#26396)
  Target specific OS for devcontainer base image (go-gitea#26422)
  Lock go to 1.21 on CI (go-gitea#26433)
  Always show usernames in reaction tooltips (go-gitea#26444)
  Fix incorrect redirection in new issue using references (go-gitea#26440)
  Fix the display of orgs listed in user profile (go-gitea#26424)
  minio: add missing region on client initialization (go-gitea#26412)
  Fix wrong middleware sequence (go-gitea#26428)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 9, 2023
@denyskon denyskon added the type/enhancement An improvement of existing functionality label Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants