Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always show usernames in reaction tooltips #26444

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Always show usernames in reaction tooltips #26444

merged 3 commits into from
Aug 10, 2023

Commits on Aug 10, 2023

  1. Always show usernames in reaction tooltips 

    Even if GetDisplayName() is normally preferred elsewhere, this change
provides more consistency, as usernames are also always being shown
when participating in a conversation taking place in an issue or a
pull request. This change makes conversations easier to follow, as
you would not have to have a mental association between someone's
username and someone's real name in order to follow what is happening.

This behavior matches GitHub's. Optimally, both the username and the
full name (if applicable) could be shown, but such an effort is a
much bigger task that needs to be thought out well.
    @n0toose
    n0toose committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    6ca0749 View commit details
    Browse the repository at this point in the history

  2. Fix test

    @n0toose
    n0toose committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    4ba3c92 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into show-usernames-in-reactions

    @GiteaBot
    GiteaBot authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    7f45fa0 View commit details
    Browse the repository at this point in the history