Unit Tests for ArrayMesh class for Issue #43440 #67800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbcolli2
force-pushed
the
ArrayMesh-UnitTests
branch
from
204fa21
to
3ee1f0c
Compare
|
Hopefully this prevents another #64854 in the future... |
|
I currently only use PrimitiveMesh arrays to test. Would it be more useful if I also tested with a mesh imported from outside of godot? |
clayjohn
reviewed
Oct 24, 2022
jbcolli2
force-pushed
the
ArrayMesh-UnitTests
branch
from
3ee1f0c
to
24a3556
Compare
clayjohn
approved these changes
Oct 25, 2022
akien-mga
approved these changes
Oct 31, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of unit tests for the
ArrayMeshclass to contribute to issue #43440. Use thePrimitiveMeshsubclasses to generate arrays to test this class.