Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(net/gclient): using the wrong header to update file #3775

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix(net/gclient): using the wrong header to update file #3775

wants to merge 5 commits into from

Conversation

oldme-git
Copy link
Member

fixed #3748

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 13, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

gqcn
gqcn requested changes Sep 19, 2024
View reviewed changes
net/gclient/gclient_request.go
httpHeaderContentTypeXml,
httpHeaderContentTypeForm}
return !gstr.InArray(notAllows, c.header[httpHeaderContentType])
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

等等，我看了下这个issue #3748 只是提了会报panic，应该是参数处理不严谨。而你这个pr做了一些枚举来允许文件上传，好像是两码事了诶？！

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前这块的上传逻辑不严谨，如果 header content-type 头是 json 或者 xml 这种不允许上传文件的头，应该将其做为一个普通的字符串上传

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gqcn gqcn gqcn requested changes

@houseme houseme houseme approved these changes

@hailaz hailaz Awaiting requested review from hailaz

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gf/net/gclient/gclient_request.go: panic while post data "@file:"
3 participants
@oldme-git @houseme @gqcn