Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(net/gclient): using the wrong header to update file #3775

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
up
  • Loading branch information
oldme-git committed Sep 13, 2024
commit 47134c7378e3874bf7011fad82be82495609a3f5
4 changes: 2 additions & 2 deletions net/gclient/gclient_request.go
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ func (c *Client) prepareRequest(ctx context.Context, method, url string, data ..
return nil, err
}
} else {
if strings.Contains(params, httpParamFileHolder) && c.allowUpdateHeader() {
if strings.Contains(params, httpParamFileHolder) && c.allowUploadHeader() {
// File uploading request.
var (
buffer = bytes.NewBuffer(nil)
Expand Down Expand Up @@ -374,7 +374,7 @@ func (c *Client) callRequest(req *http.Request) (resp *Response, err error) {
return resp, err
}

func (c *Client) allowUpdateHeader() bool {
func (c *Client) allowUploadHeader() bool {
var notAllows = []string{
httpHeaderContentTypeJson,
httpHeaderContentTypeXml,
Expand Down
Loading