Skip to content

Commit

Permalink
Fix typos in common.sh (#18151)
Browse files Browse the repository at this point in the history
* Fix typos in common.sh

Signed-off-by: Maxi_Mega <52792549+Maxi-Mega@users.noreply.github.com>

* Apply suggestions from code review

Signed-off-by: Orlix <OrlinVasilev@users.noreply.github.com>

* Add a new line at the end of make/common.sh

Co-authored-by: Orlix <OrlinVasilev@users.noreply.github.com>
Signed-off-by: Maxi_Mega <52792549+Maxi-Mega@users.noreply.github.com>

---------

Signed-off-by: Maxi_Mega <52792549+Maxi-Mega@users.noreply.github.com>
Signed-off-by: Orlix <OrlinVasilev@users.noreply.github.com>
Co-authored-by: Orlix <OrlinVasilev@users.noreply.github.com>
  • Loading branch information
Maxi-Mega and OrlinVasilev authored Apr 17, 2023
1 parent eec5342 commit 96bc43f
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions make/common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@ set -e
function check_golang {
if ! go version &> /dev/null
then
warn "No golang package in your enviroment. You should use golang docker image build binary."
warn "No golang package in your environment. You should use golang docker image build binary."
return
fi

# docker has been installed and check its version
# golang has been installed and check its version
if [[ $(go version) =~ (([0-9]+)\.([0-9]+)([\.0-9]*)) ]]
then
golang_version=${BASH_REMATCH[1]}
Expand Down Expand Up @@ -133,4 +133,6 @@ function check_dockercompose {
error "Failed to parse docker-compose version."
exit 1
fi
}
}


0 comments on commit 96bc43f

Please sign in to comment.