Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in common.sh #18151

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Fix typos in common.sh #18151

merged 3 commits into from
Apr 17, 2023

Conversation

Maxi-Mega
Copy link
Contributor

@Maxi-Mega Maxi-Mega commented Jan 31, 2023

Signed-off-by: Maxi_Mega 52792549+Maxi-Mega@users.noreply.github.com

Comprehensive Summary of your change

  • Fix two typos in make/common.sh

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #18151 (1513ff8) into main (eec5342) will increase coverage by 22.70%.
The diff coverage is n/a.

❗ Current head 1513ff8 differs from pull request most recent head 09c6910. Consider uploading reports for the commit 09c6910 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #18151       +/-   ##
===========================================
+ Coverage   44.68%   67.39%   +22.70%     
===========================================
  Files         235      984      +749     
  Lines       13089   106980    +93891     
  Branches     2670     2670               
===========================================
+ Hits         5849    72099    +66250     
- Misses       6946    31001    +24055     
- Partials      294     3880     +3586     
Flag Coverage Δ
unittests 67.39% <ø> (+22.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 754 files with indirect coverage changes

Copy link
Member

@OrlinVasilev OrlinVasilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Maxi-Mega thanks for considering contribution to our project :) please add new line at the end!

Thank you!

Copy link
Member

@OrlinVasilev OrlinVasilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Maxi-Mega and others added 3 commits April 17, 2023 15:07
Signed-off-by: Maxi_Mega <52792549+Maxi-Mega@users.noreply.github.com>
Signed-off-by: Orlix <OrlinVasilev@users.noreply.github.com>
Co-authored-by: Orlix <OrlinVasilev@users.noreply.github.com>
Signed-off-by: Maxi_Mega <52792549+Maxi-Mega@users.noreply.github.com>
@chlins chlins merged commit 96bc43f into goharbor:main Apr 17, 2023
@Maxi-Mega Maxi-Mega deleted the patch-1 branch April 17, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants