Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in common.sh #18151

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Fix typos in common.sh #18151

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b89c0a
Fix typos in common.sh
Maxi-Mega Jan 31, 2023
f0164fb
Apply suggestions from code review
OrlinVasilev Feb 1, 2023
09c6910
Add a new line at the end of make/common.sh
Maxi-Mega Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions make/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@ set -e
function check_golang {
if ! go version &> /dev/null
then
warn "No golang package in your enviroment. You should use golang docker image build binary."
warn "No golang package in your environment. You should use golang docker image build binary."
return
fi

# docker has been installed and check its version
# golang has been installed and check its version
if [[ $(go version) =~ (([0-9]+)\.([0-9]+)([\.0-9]*)) ]]
then
golang_version=${BASH_REMATCH[1]}
Expand Down Expand Up @@ -133,4 +133,6 @@ function check_dockercompose {
error "Failed to parse docker-compose version."
exit 1
fi
}
}
Maxi-Mega marked this conversation as resolved.
Show resolved Hide resolved