typecheck: support Go 1.20 #3420

codefromthecrypt · 2022-12-14T00:40:36Z

Your feature request related to a problem? Please describe.

I tried to run linters that pass now, on go 1.20rc1, but some are failing suspiciously in typecheck.

For example, certain exported symbols in the same package show up as undeclared.

imports/go/gojs.go:30:32: undeclared name: `RoundTripperKey` (typecheck)
	return context.WithValue(ctx, RoundTripperKey{}, rt)
	                              ^

Another example, is it seems you have to add return after a panic now?

        panic(fmt.Sprintf("TODO: fetchPromise.%s", method))
+       return nil, nil

I stopped here

Describe the solution you'd like.

I would like to be able to test release candidates

Describe alternatives you've considered.

waiting

Additional context.

I installed go using gimme 1.20rc1 and ran make lint on https://github.com/tetratelabs/wazero

The text was updated successfully, but these errors were encountered:

boring-cyborg · 2022-12-14T00:40:38Z

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

aarongable · 2022-12-15T00:26:16Z

@ldez Can you provide some insight into what causes these typecheck failures when running golangci-lint on a brand-new version of Go? Nothing about generics, interfaces, or exported symbols changed in this release. Why does the Go version bump cause problems for typecheck? If we can figure that out, then maybe we can avoid having to do this "can't run golangci-lint on Go release candidates" dance every time a new version comes out.

bombsimon · 2022-12-15T07:20:26Z

We have some documentation work to do because this is a very common question.

In short typechec is not a real linter but a way for golangci-lint to report compilation errors. In the majority of cases when you get typecheck issues your code does not compile when doing go build ./... on the same machine.

If something breaks in a version bump it's most likely because the code uses some kind of feature that's not supported in the go version golangci-lint was compiled with.

aarongable · 2022-12-15T20:08:52Z

Apologies for the ping, you're totally right.

My confusion arises because my project consumes golang-ci lint by building it ourselves. We produce a container image with a specific version of Go that we want to test on, then use go install to get golangci-lint, then run it against our codebase. In the same container image, all of the project code compiles and tests just fine.

bombsimon · 2022-12-15T21:05:14Z

Yeah I can undertand the confusion. Thanks for the extra info. I did a quick local test with go1.20, building golangcilintfrom master and also tried from thev1.50.1` tag, and it seem to be working fine.

$ go1.20rc1 version
go version go1.20rc1 darwin/arm64

$ go1.20rc1 build -o /tmp/golangci-lint ./cmd/golangci-lint/

$ /tmp/golangci-lint run ./...
test/akamai-test-srv/main.go:95:15: G114: Use of net/http serve function that has no support for setting timeouts (gosec)
        go log.Fatal(http.ListenAndServe(*listenAddr, nil))
                     ^
test/s3-test-srv/main.go:96:15: G114: Use of net/http serve function that has no support for setting timeouts (gosec)
        go log.Fatal(http.ListenAndServe(*listenAddr, nil))
                     ^
test/mail-test-srv/main.go:227:10: G114: Use of net/http serve function that has no support for setting timeouts (gosec)
                err := http.ListenAndServe(*listenAPI, http.DefaultServeMux)
                       ^

Are you able to reproduce this locally yourself?

aarongable · 2022-12-15T23:07:54Z

Hmm, yep, I can repeat those steps and get those results (with no errors, because I've fixed those three gosec findings) when running locally:

$ where golangci-lint
/home/aaron/.local/share/go/bin/golangci-lint

$ strings /home/aaron/.local/share/go/bin/golangci-lint | grep 'go1\.20rc1' | head -n1
go1.20rc1

$ golangci-lint run ./...

But doing the same exact thing inside the container results in an error related to the netip package:

$ BOULDER_TOOLS_TAG=go1.20rc1_2022-12-14 docker-compose run boulder which golangci-lint
<snip>
/usr/local/bin/golangci-lint

$ BOULDER_TOOLS_TAG=go1.20rc1_2022-12-14 docker-compose run boulder strings /usr/local/bin/golangci-lint | grep 'go1\.20rc1'
<snip>
go1.20rc1

$ BOULDER_TOOLS_TAG=go1.20rc1_2022-12-14 docker-compose run boulder /usr/local/bin/golangci-lint run ./...
<snip>
ERRO [runner] Panic: buildir: package "netip" (isInitialPkg: false, needAnalyzeSource: true): in net/netip.AddrFromSlice: cannot convert Load <[]byte> t0 ([]byte) to [4]byte: goroutine 8525 [running]:
runtime/debug.Stack()
	/usr/local/go/src/runtime/debug/stack.go:24 +0x65
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe.func1()
	/root/go/pkg/mod/github.com/golangci/golangci-lint@v1.50.1/pkg/golinters/goanalysis/runner_action.go:102 +0x155
panic({0x14fe300, 0xc00141e810})
	/usr/local/go/src/runtime/panic.go:884 +0x213
honnef.co/go/tools/go/ir.emitConv(0xc0030b0b40, {0x19396c8, 0xc004068a80}, {0x192cbb0?, 0xc0064fc720}, {0x192c2a0, 0xc00ade4140})
	/root/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/emit.go:293 +0xd29
honnef.co/go/tools/go/ir.(*builder).expr0(0xc00364da28, 0xc0030b0b40, {0x192ff70?, 0xc00ade4140?}, {0x7, {0x192cbb0, 0xc0064fc720}, {0x0, 0x0}})
	/root/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:610 +0x5d7
honnef.co/go/tools/go/ir.(*builder).expr(0x192cd40?, 0xc0030b0b40, {0x192ff70, 0xc00ade4140})
	/root/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:566 +0x1fa
honnef.co/go/tools/go/ir.(*builder).emitCallArgs(0x192cd40?, 0xc0030b0b40, 0xc00a090000, 0xc00ade4180, {0x0?, 0x0, 0x8b80c7?})
	/root/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:975 +0x135
honnef.co/go/tools/go/ir.(*builder).setCall(0x1567e20?, 0xc0030b0b40, 0xc00ade4180, 0xc003797c68)
	/root/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:1037 +0x8e
honnef.co/go/tools/go/ir.(*builder).expr0(0xc00364da28, 0xc0030b0b40, {0x192ff70?, 0xc00ade4180?}, {0x7, {0x192cca0, 0xc00928fe30}, {0x0, 0x0}})
	/root/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:623 +0x218e
honnef.co/go/tools/go/ir.(*builder).expr(0xc00364ce78?, 0xc0030b0b40, {0x192ff70, 0xc00ade4180})
	/root/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:566 +0x1fa
honnef.co/go/tools/go/ir.(*builder).stmt(0xc0030b0b40?, 0xc0030b0b40, {0x19304b0?, 0xc0060273a0?})
	/root/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:2291 +0x194c
honnef.co/go/tools/go/ir.(*builder).stmtList(...)
	/root/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:855
honnef.co/go/tools/go/ir.(*builder).switchStmt(0xc00364d308?, 0xc0030b0b40, 0xc00b0a77d0, 0x0)
	/root/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:1366 +0x19a5
honnef.co/go/tools/go/ir.(*builder).stmt(0x20?, 0xc0030b0b40, {0x1930600?, 0xc00b0a77d0?})
	/root/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:2365 +0x121c
honnef.co/go/tools/go/ir.(*builder).stmtList(0x8bea45?, 0xc00364d4f8?, {0xc006027560?, 0x2, 0x8c0650?})
	/root/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:855 +0x45
honnef.co/go/tools/go/ir.(*builder).stmt(0xc0030b0b40?, 0xc0030b0b40, {0x192ff10?, 0xc00b0a7800?})
	/root/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:2338 +0x9b9
honnef.co/go/tools/go/ir.(*builder).buildFunction(0xc00364da28, 0xc0030b0b40)
	/root/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:2450 +0x3d7
honnef.co/go/tools/go/ir.(*builder).buildFuncDecl(0x0?, 0xc00584d4d0, 0xc00b0a7830)
	/root/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:2488 +0x19b
honnef.co/go/tools/go/ir.(*Package).build(0xc00584d4d0)
	/root/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:2594 +0xc16
sync.(*Once).doSlow(0xc0040aa000?, 0xc005d40730?)
	/usr/local/go/src/sync/once.go:74 +0xc2
sync.(*Once).Do(...)
	/usr/local/go/src/sync/once.go:65
honnef.co/go/tools/go/ir.(*Package).Build(...)
	/root/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:2512
honnef.co/go/tools/internal/passes/buildir.run(0xc00f231860)
	/root/go/pkg/mod/honnef.co/go/tools@v0.3.3/internal/passes/buildir/buildir.go:86 +0x368
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyze(0xc0050fd300)
	/root/go/pkg/mod/github.com/golangci/golangci-lint@v1.50.1/pkg/golinters/goanalysis/runner_action.go:188 +0x9d6
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe.func2()
	/root/go/pkg/mod/github.com/golangci/golangci-lint@v1.50.1/pkg/golinters/goanalysis/runner_action.go:106 +0x1d
github.com/golangci/golangci-lint/pkg/timeutils.(*Stopwatch).TrackStage(0xc002932ff0, {0x16c9b40, 0x7}, 0xc0032ef748)
	/root/go/pkg/mod/github.com/golangci/golangci-lint@v1.50.1/pkg/timeutils/stopwatch.go:111 +0x4a
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe(0xc00097e780?)
	/root/go/pkg/mod/github.com/golangci/golangci-lint@v1.50.1/pkg/golinters/goanalysis/runner_action.go:105 +0x85
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*loadingPackage).analyze.func2(0xc0050fd300)
	/root/go/pkg/mod/github.com/golangci/golangci-lint@v1.50.1/pkg/golinters/goanalysis/runner_loadingpackage.go:80 +0xb4
created by github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*loadingPackage).analyze
	/root/go/pkg/mod/github.com/golangci/golangci-lint@v1.50.1/pkg/golinters/goanalysis/runner_loadingpackage.go:75 +0x1eb
WARN [runner] Can't run linter goanalysis_metalinter: goanalysis_metalinter: buildir: package "netip" (isInitialPkg: false, needAnalyzeSource: true): in net/netip.AddrFromSlice: cannot convert Load <[]byte> t0 ([]byte) to [4]byte
ERRO Running error: 1 error occurred:
	* can't run linter goanalysis_metalinter: goanalysis_metalinter: buildir: package "netip" (isInitialPkg: false, needAnalyzeSource: true): in net/netip.AddrFromSlice: cannot convert Load <[]byte> t0 ([]byte) to [4]byte

Anyway, it seems likely this isn't strictly a golangci-lint issue at this point, it's likely more closely related to our container environment. Thanks for your help, and let me know if you've got any ideas!

atc0005 · 2022-12-15T23:19:46Z

Are you able to reproduce this locally yourself?

Additional notes (in case they provide any additional details):

cd $HOME/Desktop
git clone https://github.com/rs/zerolog
cd zerolog
docker image pull golang:1.20rc1
docker container run -it --rm -v $PWD:$PWD -w $PWD golang:1.20rc1
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.50.1
golangci-lint --version
golangci-lint run ./...

Output from the last command:

root@8243eca418db:/home/ubuntu/Desktop/zerolog# golangci-lint run ./...
ERRO [runner] Panic: buildir: package "netip" (isInitialPkg: false, needAnalyzeSource: true): in net/netip.AddrFromSlice: cannot convert Load <[]byte> t0 ([]byte) to [4]byte: goroutine 1673 [running]:
runtime/debug.Stack()
	/usr/local/go/src/runtime/debug/stack.go:24 +0x65
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe.func1()
	/go/pkg/mod/github.com/golangci/golangci-lint@v1.50.1/pkg/golinters/goanalysis/runner_action.go:102 +0x155
panic({0x14fd300, 0xc003570ee0})
	/usr/local/go/src/runtime/panic.go:884 +0x213
honnef.co/go/tools/go/ir.emitConv(0xc0024db7c0, {0x19386c8, 0xc0028df620}, {0x192bbb0?, 0xc00b142c30}, {0x192b2a0, 0xc011ba8180})
	/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/emit.go:293 +0xd29
honnef.co/go/tools/go/ir.(*builder).expr0(0xc000023a28, 0xc0024db7c0, {0x192ef70?, 0xc011ba8180?}, {0x7, {0x192bbb0, 0xc00b142c30}, {0x0, 0x0}})
	/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:610 +0x5d7
honnef.co/go/tools/go/ir.(*builder).expr(0x192bd40?, 0xc0024db7c0, {0x192ef70, 0xc011ba8180})
	/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:566 +0x1fa
honnef.co/go/tools/go/ir.(*builder).emitCallArgs(0x192bd40?, 0xc0024db7c0, 0xc0014d8000, 0xc011ba81c0, {0x0?, 0x0, 0x8b80a7?})
	/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:975 +0x135
honnef.co/go/tools/go/ir.(*builder).setCall(0x1566e20?, 0xc0024db7c0, 0xc011ba81c0, 0xc0028d1ee8)
	/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:1037 +0x8e
honnef.co/go/tools/go/ir.(*builder).expr0(0xc000023a28, 0xc0024db7c0, {0x192ef70?, 0xc011ba81c0?}, {0x7, {0x192bca0, 0xc00aac91f0}, {0x0, 0x0}})
	/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:623 +0x218e
honnef.co/go/tools/go/ir.(*builder).expr(0xc000022e78?, 0xc0024db7c0, {0x192ef70, 0xc011ba81c0})
	/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:566 +0x1fa
honnef.co/go/tools/go/ir.(*builder).stmt(0xc0024db7c0?, 0xc0024db7c0, {0x192f4b0?, 0xc0081a3d80?})
	/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:2291 +0x194c
honnef.co/go/tools/go/ir.(*builder).stmtList(...)
	/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:855
honnef.co/go/tools/go/ir.(*builder).switchStmt(0x22770a0?, 0xc0024db7c0, 0xc0018025a0, 0x0)
	/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:1366 +0x19a5
honnef.co/go/tools/go/ir.(*builder).stmt(0x20?, 0xc0024db7c0, {0x192f600?, 0xc0018025a0?})
	/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:2365 +0x121c
honnef.co/go/tools/go/ir.(*builder).stmtList(0x8bea25?, 0xc0000234f8?, {0xc0081a3fc0?, 0x2, 0x8c0630?})
	/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:855 +0x45
honnef.co/go/tools/go/ir.(*builder).stmt(0xc0024db7c0?, 0xc0024db7c0, {0x192ef10?, 0xc0018025d0?})
	/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:2338 +0x9b9
honnef.co/go/tools/go/ir.(*builder).buildFunction(0xc000023a28, 0xc0024db7c0)
	/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:2450 +0x3d7
honnef.co/go/tools/go/ir.(*builder).buildFuncDecl(0x0?, 0xc002414480, 0xc001802600)
	/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:2488 +0x19b
honnef.co/go/tools/go/ir.(*Package).build(0xc002414480)
	/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:2594 +0xc16
sync.(*Once).doSlow(0xc0039dc9a0?, 0xc004e60af0?)
	/usr/local/go/src/sync/once.go:74 +0xc2
sync.(*Once).Do(...)
	/usr/local/go/src/sync/once.go:65
honnef.co/go/tools/go/ir.(*Package).Build(...)
	/go/pkg/mod/honnef.co/go/tools@v0.3.3/go/ir/builder.go:2512
honnef.co/go/tools/internal/passes/buildir.run(0xc002afef70)
	/go/pkg/mod/honnef.co/go/tools@v0.3.3/internal/passes/buildir/buildir.go:86 +0x368
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyze(0xc0014dfc40)
	/go/pkg/mod/github.com/golangci/golangci-lint@v1.50.1/pkg/golinters/goanalysis/runner_action.go:188 +0x9d6
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe.func2()
	/go/pkg/mod/github.com/golangci/golangci-lint@v1.50.1/pkg/golinters/goanalysis/runner_action.go:106 +0x1d
github.com/golangci/golangci-lint/pkg/timeutils.(*Stopwatch).TrackStage(0xc0011d09b0, {0x16c8b40, 0x7}, 0xc0018dc748)
	/go/pkg/mod/github.com/golangci/golangci-lint@v1.50.1/pkg/timeutils/stopwatch.go:111 +0x4a
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe(0xc0010a47e0?)
	/go/pkg/mod/github.com/golangci/golangci-lint@v1.50.1/pkg/golinters/goanalysis/runner_action.go:105 +0x85
github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*loadingPackage).analyze.func2(0xc0014dfc40)
	/go/pkg/mod/github.com/golangci/golangci-lint@v1.50.1/pkg/golinters/goanalysis/runner_loadingpackage.go:80 +0xb4
created by github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*loadingPackage).analyze
	/go/pkg/mod/github.com/golangci/golangci-lint@v1.50.1/pkg/golinters/goanalysis/runner_loadingpackage.go:75 +0x1eb 
WARN [runner] Can't run linter goanalysis_metalinter: goanalysis_metalinter: buildir: package "netip" (isInitialPkg: false, needAnalyzeSource: true): in net/netip.AddrFromSlice: cannot convert Load <[]byte> t0 ([]byte) to [4]byte 
ERRO Running error: 1 error occurred:
	* can't run linter goanalysis_metalinter: goanalysis_metalinter: buildir: package "netip" (isInitialPkg: false, needAnalyzeSource: true): in net/netip.AddrFromSlice: cannot convert Load <[]byte> t0 ([]byte) to [4]byte

shuLhan · 2022-12-16T11:33:02Z

@atc0005 I believe this is an issue that has been reported go-tools module and fixed [1].

[1] dominikh/go-tools#1335

codefromthecrypt · 2023-02-02T07:52:15Z

I think this issue will start getting spam levels of interest now that go 1.20 is out

codefromthecrypt · 2023-02-02T08:10:15Z

thanks tons @ldez

typecheck seems to not play nice with go 1.20[1]. with the current version of golangci-lint we are using. bump to latest release. [1] golangci/golangci-lint#3420 Signed-off-by: adrianc <adrianc@nvidia.com>

typecheck linter does not play nice with go 1.20[1] bump golangci-lint version to 1.51.2 [1] golangci/golangci-lint#3420 Signed-off-by: adrianc <adrianc@nvidia.com>

typecheck seems to not play nice with go 1.20[1]. with the current version of golangci-lint we are using. bump to latest release. [1] golangci/golangci-lint#3420 Signed-off-by: adrianc <adrianc@nvidia.com>

This required to work correctly with golang-1.20. Versions of golangci-lint prior to 1.50 would often crash/hang with golang-1.20 due to that version's addition of slice-to-array. See golangci/golangci-lint#3420

typecheck seems to not play nice with go 1.20[1]. with the current version of golangci-lint we are using. bump to latest release. [1] golangci/golangci-lint#3420 Signed-off-by: adrianc <adrianc@nvidia.com>

- add manual scanning of github keys, it is required since webfactory/ssh-agen `v0.8.0` S. https://github.com/webfactory/ssh-agent/releases - remove hard-coded golang version, always build with the one from `go.mod`. Note: it requires the checkout to be done *before* setting up the go action, otherwise the version cannot be determined, obviously - bump golangci-lint version to `v1.53.3`. `v1.50.*` is not compatible with golang `1.20`, s. golangci/golangci-lint#3420

…ally fixed in #2204)

codefromthecrypt added the enhancement New feature or improvement label Dec 14, 2022

codefromthecrypt mentioned this issue Dec 14, 2022

update build to go 1.20 tetratelabs/wazero#921

Closed

ldez mentioned this issue Dec 14, 2022

go1.20 support #3414

Merged

ldez self-assigned this Dec 16, 2022

MadhavJivrajani mentioned this issue Dec 25, 2022

[go] Bump images, dependencies and versions to go 1.20 kubernetes/kubernetes#114502

Merged

jchadwick-buf mentioned this issue Feb 1, 2023

Update to Go 1.20 bufbuild/buf#1785

Merged

aarongable mentioned this issue Feb 1, 2023

goanalysis_metalinter panics on go1.20 netip package #3533

Closed

4 tasks

ldez closed this as completed in #3414 Feb 2, 2023

adrianchiris mentioned this issue Feb 26, 2023

Bump golangci-lint version k8snetworkplumbingwg/ib-sriov-cni#77

Merged

adrianchiris mentioned this issue Feb 26, 2023

bump golangci-lint version k8snetworkplumbingwg/accelerated-bridge-cni#69

Merged

healthy-pod mentioned this issue Feb 27, 2023

*: upgrade to go 1.21.0 cockroachdb/cockroach#97260

Closed

15 tasks

evantorrie mentioned this issue Mar 2, 2023

Upgrade internal/tools versions signalfx/splunk-otel-collector#2642

Merged

vkhoroz mentioned this issue Mar 6, 2023

Bump golangci-ling to 1.51.2 foundriesio/fioctl#227

Merged

Daniel-Fan mentioned this issue Mar 10, 2023

bump golangci-lint to v1.51.2 for go 1.20 support IBM/test-infra#530

Merged

z103cb mentioned this issue Aug 17, 2023

Bump the golangci-lint version in the api server makefile ray-project/kuberay#1342

Merged

4 tasks

trajan0x added a commit to synapsecns/sanguine that referenced this issue Mar 21, 2024

attempt to fix golangci-lint (golangci/golangci-lint#3420), theoretic…

275bb8f

…ally fixed in #2204)

This was referenced Mar 21, 2024

attempt to fix golangci-lint synapsecns/sanguine#2331

Closed

fix golangci-lint synapsecns/sanguine#2334

Merged

deepakm-ntnx mentioned this issue Apr 22, 2024

build: Minor golangci-lint config updates for recent versions nutanix-cloud-native/cluster-api-runtime-extensions-nutanix#552

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

typecheck: support Go 1.20 #3420

typecheck: support Go 1.20 #3420

codefromthecrypt commented Dec 14, 2022

boring-cyborg bot commented Dec 14, 2022

aarongable commented Dec 15, 2022

bombsimon commented Dec 15, 2022 •

edited

Loading

aarongable commented Dec 15, 2022

bombsimon commented Dec 15, 2022

aarongable commented Dec 15, 2022

atc0005 commented Dec 15, 2022

shuLhan commented Dec 16, 2022

codefromthecrypt commented Feb 2, 2023

codefromthecrypt commented Feb 2, 2023

typecheck: support Go 1.20 #3420

typecheck: support Go 1.20 #3420

Comments

codefromthecrypt commented Dec 14, 2022

Your feature request related to a problem? Please describe.

Describe the solution you'd like.

Describe alternatives you've considered.

Additional context.

boring-cyborg bot commented Dec 14, 2022

aarongable commented Dec 15, 2022

bombsimon commented Dec 15, 2022 • edited Loading

aarongable commented Dec 15, 2022

bombsimon commented Dec 15, 2022

aarongable commented Dec 15, 2022

atc0005 commented Dec 15, 2022

shuLhan commented Dec 16, 2022

codefromthecrypt commented Feb 2, 2023

codefromthecrypt commented Feb 2, 2023

bombsimon commented Dec 15, 2022 •

edited

Loading