Skip to content

Commit

Permalink
Bump golangci-lint version (#77)
Browse files Browse the repository at this point in the history
typecheck seems to not play nice with go 1.20[1].
with the current version of golangci-lint we are using.

bump to latest release.

[1] golangci/golangci-lint#3420

Signed-off-by: adrianc <adrianc@nvidia.com>
  • Loading branch information
adrianchiris authored and vrindle committed May 3, 2023
1 parent 981a748 commit 7709319
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 9 deletions.
11 changes: 3 additions & 8 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,11 @@ linters-settings:
min-complexity: 30
goimports:
local-prefixes: github.com/Mellanox/ib-sriov-cni
golint:
min-confidence: 0
gomnd:
settings:
mnd:
# don't include the "operation" and "assign"
checks: argument,case,condition,return
checks: [argument,case,condition,return]
govet:
check-shadowing: true
settings:
Expand All @@ -55,19 +53,18 @@ linters:
disable-all: true
enable:
- bodyclose
- deadcode
- depguard
- dogsled
- dupl
- errcheck
- exportloopref
- funlen
- gochecknoinits
- goconst
- gocritic
- gocognit
- gofmt
- goimports
- golint
- gomnd
- goprintffuncname
- gosec
Expand All @@ -78,16 +75,14 @@ linters:
- misspell
- nakedret
- prealloc
- revive
- rowserrcheck
- scopelint
- staticcheck
- structcheck
- stylecheck
- typecheck
- unconvert
- unparam
- unused
- varcheck
- whitespace

issues:
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ GOLANGCI_LINT = $(GOBIN)/golangci-lint
# golangci-lint version should be updated periodically
# we keep it fixed to avoid it from unexpectedly failing on the project
# in case of a version bump
GOLANGCI_LINT_VER = v1.46.2
GOLANGCI_LINT_VER = v1.51.2
TIMEOUT = 15
Q = $(if $(filter 1,$V),,@)

Expand Down

0 comments on commit 7709319

Please sign in to comment.