Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance/#8134 - Implement the unhappy paths for the Setup CTA Banner #8866

Merged
merged 52 commits into from
Jul 4, 2024

Conversation

hussain-t
Copy link
Collaborator

@hussain-t hussain-t commented Jun 13, 2024

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Jun 13, 2024

Build files for 40bc804 have been deleted.

Copy link

github-actions bot commented Jun 13, 2024

Size Change: +5.53 kB (+0.35%)

Total Size: 1.57 MB

Filename Size Change
./dist/assets/js/35-********************.js 3.12 kB +1 B (+0.03%)
./dist/assets/js/googlesitekit-activation-********************.js 24 kB +51 B (+0.21%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 59.5 kB +116 B (+0.2%)
./dist/assets/js/googlesitekit-adminbar-********************.js 34.8 kB +76 B (+0.22%)
./dist/assets/js/googlesitekit-api-********************.js 10.2 kB +7 B (+0.07%)
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.87 kB -6 B (-0.1%)
./dist/assets/js/googlesitekit-data-********************.js 2.37 kB +3 B (+0.13%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.13 kB +1 B (+0.01%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 20 kB +94 B (+0.47%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10.1 kB +1 B (+0.01%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 25.1 kB -2 B (-0.01%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 74.1 kB +74 B (+0.1%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 125 kB +1.12 kB (+0.91%)
./dist/assets/js/googlesitekit-modules-********************.js 22.2 kB +4 B (+0.02%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 29.6 kB +82 B (+0.28%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 113 kB +117 B (+0.1%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 144 kB +1.05 kB (+0.74%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.6 kB +3 B (+0.01%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 11.3 kB -1 B (-0.01%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 58.4 kB -5 B (-0.01%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 31.9 kB +9 B (+0.03%)
./dist/assets/js/googlesitekit-polyfills-********************.js 378 B +1 B (+0.27%)
./dist/assets/js/googlesitekit-settings-********************.js 61.7 kB +131 B (+0.21%)
./dist/assets/js/googlesitekit-splash-********************.js 73.5 kB +642 B (+0.88%)
./dist/assets/js/googlesitekit-user-input-********************.js 48.3 kB +152 B (+0.32%)
./dist/assets/js/googlesitekit-vendor-********************.js 317 kB -1 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 62.4 kB +1.78 kB (+2.94%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 61.6 kB +26 B (+0.04%)
./dist/assets/js/runtime-********************.js 1.3 kB -2 B (-0.15%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 55.1 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.2 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 770 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 7.47 kB
./dist/assets/js/30-********************.js 2.76 kB
./dist/assets/js/31-********************.js 2.25 kB
./dist/assets/js/32-********************.js 3.64 kB
./dist/assets/js/33-********************.js 935 B
./dist/assets/js/34-********************.js 892 B
./dist/assets/js/analytics-advanced-tracking-********************.js 776 B
./dist/assets/js/contact-form-7-********************.js 645 B
./dist/assets/js/easy-digital-downloads-********************.js 615 B
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/mailchimp-********************.js 629 B
./dist/assets/js/ninja-forms-********************.js 727 B
./dist/assets/js/optin-monster-********************.js 673 B
./dist/assets/js/popup-maker-********************.js 634 B
./dist/assets/js/woocommerce-********************.js 652 B
./dist/assets/js/wpforms-********************.js 632 B

compressed-size-action

Rearrage imports and props.
Retry failed audience creation.
Pass correct get help link ot the oauth variant.
Copy link
Collaborator

@techanvil techanvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hussain-t, this is off to a decent start but there are a few logical errors to address.

Please take a look, and feel free to give me a shout if anything needs further clarification.

@hussain-t
Copy link
Collaborator Author

Thanks for the detailed review, @techanvil. It's back with you for another round.

Copy link
Collaborator

@techanvil techanvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @hussain-t!

@techanvil techanvil merged commit 09ca319 into develop Jul 4, 2024
23 of 24 checks passed
@techanvil techanvil deleted the enhance/#8134-audience-setup-cta-unhappy-paths branch July 4, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants