-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance/#8134 - Implement the unhappy paths for the Setup CTA Banner #8866
Enhance/#8134 - Implement the unhappy paths for the Setup CTA Banner #8866
Conversation
Build files for 40bc804 have been deleted. |
Size Change: +5.53 kB (+0.35%) Total Size: 1.57 MB
ℹ️ View Unchanged
|
Rearrage imports and props.
Retry failed audience creation.
Pass correct get help link ot the oauth variant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hussain-t, this is off to a decent start but there are a few logical errors to address.
Please take a look, and feel free to give me a shout if anything needs further clarification.
assets/js/components/PermissionsModal/AuthenticatedPermissionsModal.js
Outdated
Show resolved
Hide resolved
assets/js/components/PermissionsModal/AuthenticatedPermissionsModal.js
Outdated
Show resolved
Hide resolved
...analytics-4/components/audience-segmentation/dashboard/AudienceSegmentationSetupCTAWidget.js
Outdated
Show resolved
Hide resolved
...analytics-4/components/audience-segmentation/dashboard/AudienceSegmentationSetupCTAWidget.js
Outdated
Show resolved
Hide resolved
...analytics-4/components/audience-segmentation/dashboard/AudienceSegmentationSetupCTAWidget.js
Outdated
Show resolved
Hide resolved
...analytics-4/components/audience-segmentation/dashboard/AudienceSegmentationSetupCTAWidget.js
Outdated
Show resolved
Hide resolved
...analytics-4/components/audience-segmentation/dashboard/AudienceSegmentationSetupCTAWidget.js
Outdated
Show resolved
Hide resolved
...analytics-4/components/audience-segmentation/dashboard/AudienceSegmentationSetupCTAWidget.js
Outdated
Show resolved
Hide resolved
Address CR feedback. Improve conditions.
Fix param name.
…c with the configured audience.
Thanks for the detailed review, @techanvil. It's back with you for another round. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work @hussain-t!
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist