Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance/#8134 - Implement the unhappy paths for the Setup CTA Banner #8866

Merged
merged 52 commits into from
Jul 4, 2024
Merged

Enhance/#8134 - Implement the unhappy paths for the Setup CTA Banner #8866

Changes from 1 commit
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
dbac5d6
Handle errors.
hussain-t Jun 12, 2024
f59c18d
Add failedSiteKitAudienceResourceNames param.
hussain-t Jun 12, 2024
91bbe56
Handle retry logic.
hussain-t Jun 13, 2024
3ad8236
Merge branch 'develop' into enhance/#8134-audience-setup-cta-unhappy-…
hussain-t Jun 24, 2024
bbb52a3
Add buttonLink prop to ModalDialog.
hussain-t Jun 24, 2024
8a604e8
Merge branch 'develop' into enhance/#8134-audience-setup-cta-unhappy-…
hussain-t Jun 25, 2024
d99fbae
Fix merge conflicts.
hussain-t Jun 25, 2024
d22d36e
Remove code duplication.
hussain-t Jun 25, 2024
64caec5
Add AudienceErrorModal component.
hussain-t Jun 25, 2024
58470bd
Render Button component if buttonLink is provided.
hussain-t Jun 25, 2024
eeb3242
Return null if skipDefaultErrorNotifications available in ErrorNotifi…
hussain-t Jun 25, 2024
6774427
Return null if skipDefaultErrorNotifications available in SetupErrorN…
hussain-t Jun 25, 2024
ee5986a
Add AudienceErrorModal stories - WIP.
hussain-t Jun 25, 2024
284cf8d
Add logic to render AudienceErrorModal in the setup CTA.
hussain-t Jun 25, 2024
b511ddd
Add enableAudienceGroup tests coverage for error handling.
hussain-t Jun 27, 2024
5a5e82f
Pass failedSiteKitAudienceResourceNames as a non object param.
hussain-t Jun 27, 2024
0ea5b01
Do not navigate to OAuth flow if skipDefaultErrorNotifications is ava…
hussain-t Jun 27, 2024
aa11356
Add onCancel prop.
hussain-t Jun 27, 2024
5cdc31b
Render AudienceErrorModal.
hussain-t Jun 27, 2024
90fe4e4
Merge branch 'develop' into enhance/#8134-audience-setup-cta-unhappy-…
hussain-t Jun 27, 2024
9772b4d
Add AudienceErrorModal tests.
hussain-t Jun 27, 2024
68611c1
Don not render the modal if no errors.
hussain-t Jun 27, 2024
81d4c82
Export default AudienceErrorModal.
hussain-t Jun 27, 2024
35a8ed4
Fix existing AudienceSegmentationSetupCTAWidget tests.
hussain-t Jun 27, 2024
ffe6c1d
Fix hasOAuthError condition to return bool.
hussain-t Jun 27, 2024
3627787
Add OAuth error modal test.
hussain-t Jun 27, 2024
0af641d
Add insufficient error variant test.
hussain-t Jun 28, 2024
e292955
Assert missing retry button assertion.
hussain-t Jun 28, 2024
e78f06d
Add generic error variant test case.
hussain-t Jun 28, 2024
baec29c
Add VRT scenario and clean up.
hussain-t Jun 28, 2024
a31c8c1
Add VRT images for AudienceErrorModal.
hussain-t Jun 28, 2024
eb335b6
Merge branch 'develop' into enhance/#8134-audience-setup-cta-unhappy-…
hussain-t Jun 28, 2024
e0cdc39
Improve conditions.
hussain-t Jun 28, 2024
6d7794b
Wrap the render call with act.
hussain-t Jun 28, 2024
2316d1a
Fix state update leaks in tests.
hussain-t Jun 30, 2024
009f4c9
Merge branch 'develop' into enhance/#8134-audience-setup-cta-unhappy-…
hussain-t Jul 2, 2024
01d1757
Revert the changes in auth permissions modal.
hussain-t Jul 2, 2024
4424a12
Fix logic errors.
hussain-t Jul 2, 2024
650fde3
Render AudienceErrorModal inside the main JSX.
hussain-t Jul 2, 2024
723e5c2
Merge branch 'develop' into enhance/#8134-audience-setup-cta-unhappy-…
hussain-t Jul 3, 2024
9973a4a
Rename param to failedSiteKitAudienceSlugs.
hussain-t Jul 3, 2024
a32b53c
Improve logic to handle successully create audiences - WIP.
hussain-t Jul 3, 2024
2daea42
Dispatch setConfiguredAudiences appropriately.
hussain-t Jul 3, 2024
65ec299
Fix and improvements.
hussain-t Jul 3, 2024
bac7eab
Add setSetupErrorCode action.
hussain-t Jul 3, 2024
77fff95
Add setSetupErrorCode action tests.
hussain-t Jul 3, 2024
6adc446
Clear OAuth error onCancel.
hussain-t Jul 3, 2024
d24032c
Update the logic to look up for the newly available audiences and syn…
hussain-t Jul 3, 2024
1f32174
Remove unnecessary condition.
hussain-t Jul 4, 2024
149be4a
Merge branch 'develop' into enhance/#8134-audience-setup-cta-unhappy-…
hussain-t Jul 4, 2024
04e6bb6
Fix tests.
hussain-t Jul 4, 2024
40bc804
Increase timeout.
hussain-t Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'develop' into enhance/#8134-audience-setup-cta-unhappy-… 
…paths.
  • Loading branch information
@hussain-t
hussain-t committed Jul 2, 2024
commit 009f4c955db6b84240df8706078b8ec76eee8a76

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.