Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow TypeScript dates to also be strings #91

Closed
grant opened this issue Mar 2, 2021 · 1 comment · Fixed by #93
Closed

Allow TypeScript dates to also be strings #91

grant opened this issue Mar 2, 2021 · 1 comment · Fixed by #93
Assignees
@grant
Labels
api: eventarc Issues related to the googleapis/google-cloudevents-nodejs API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@grant
Copy link
Contributor

grant commented Mar 2, 2021

Expected Behavior

In a few types, we use the TypeScript Date field. We should allow strings with Date | string

Actual Behavior

We only use Date

Example:

google-cloudevents-nodejs/firebase/auth/v1/AuthEventData.ts

Line 82 in d54cfbe

createdAt?: Date;

@product-auto-label product-auto-label bot added the api: eventarc Issues related to the googleapis/google-cloudevents-nodejs API. label Mar 2, 2021
@grant grant mentioned this issue Mar 2, 2021
Closed
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Mar 3, 2021
@averikitsch averikitsch added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Mar 4, 2021
@grant grant mentioned this issue May 21, 2021
Merged
@grant grant self-assigned this May 21, 2021
@grant
Copy link
Contributor Author

grant commented May 21, 2021

I've created a PR that fixes this.

@grant grant closed this as completed in #93 Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grant grant

Labels
api: eventarc Issues related to the googleapis/google-cloudevents-nodejs API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: allow date types to be strings | re-runs the generator googleapis/google-cloudevents-nodejs
3 participants
@grant @averikitsch @yoshi-automation