Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pub/sub publishTime. Update doc comments #90

Closed
wants to merge 2 commits into from
Closed

feat: add pub/sub publishTime. Update doc comments #90

wants to merge 2 commits into from

Conversation

grant
Copy link
Contributor

@grant grant commented Feb 25, 2021

  • re-runs the generator February, 2021
  • There shouldn't be breaking changes

@grant
feat: add pub/sub publishTime. Update doc comments
b1063a5 
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant grant self-assigned this Feb 25, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 25, 2021
@product-auto-label product-auto-label bot added the api: eventarc Issues related to the googleapis/google-cloudevents-nodejs API. label Feb 25, 2021
@grant
Copy link
Contributor Author

grant commented Feb 25, 2021

Looks like this PR needs some work as we publish the interface "Date", but really need "Date | string" for our use-case.

@grant
Copy link
Contributor Author

grant commented Mar 2, 2021

Actually, the Date improvement is an add / feature request tangential to this PR.

Filed that here: #91

@grant grant removed the request for review from michaelawyu March 9, 2021 20:51
@grant grant closed this Mar 9, 2021
@grant grant deleted the grant_gen_2021_02 branch March 9, 2021 20:59
@grant
Copy link
Contributor Author

grant commented Mar 9, 2021

Would like to get Date issue first before regenerating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grayside grayside grayside approved these changes

Assignees

@grant grant

Labels
api: eventarc Issues related to the googleapis/google-cloudevents-nodejs API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grant @grayside