fix!: allow date types to be strings | re-runs the generator

[grant]

Fixes #91

• Allows Google CloudEvent date types to be either a JS date object or a string. (APIs return strings)
• Re-runs the generator (includes very minor breaking changes with TS field capitalization). The generator has not been run in a few months.

[grayside]

With this change, does using the library mean the unmarshalled data could be string or date? If so, should we have a conversion mechanism under the hood that converts the string to a Date for consistent behavior?

[grant]

With this change, does using the library mean the unmarshalled data could be string or date? If so, should we have a conversion mechanism under the hood that converts the string to a Date for consistent behavior?

Thanks for the question. In JavaScript, a Date object is stringified when passed as JSON. The conversion of the Date object to string is automatic when calling JSON.stringify or passing the data around

This change allows for the TypeScript types of date types to be strings, as that is the serialized format they come in over HTTP / over JSON.

We could create a function that parses the date string into a Date object when converting to a type, although that has trade-offs (not everyone wants JS dates) and would be a tangential feature to this PR.

WDYT @grayside ?

[grayside]

Given that clarification, and that we're calling this a breaking change (is it?), when would we receive a Date object? Maybe this should only use string?

[grant]

Given that clarification, and that we're calling this a breaking change (is it?), when would we receive a Date object? Maybe this should only use string?

A developer should be able to pass a native JS date object in the TypeScript interface without the TS compiler complaining. Right now we are only receiving these types from Eventarc, but they can also be created. A JS developer would expect to pass Date fields and not have to stringify it before using a type.

Only string would be one option, but Date or string would be better.