Skip to content

Commit

Permalink
chore: do not use renovate to update protobuf (#3190)
Browse files Browse the repository at this point in the history
In this PR:
- Do not use renovate to update protobuf version in
`gax-java/dependencies.properties`.

We need to make sure the protobuf version in
`gax-java/dependency.properties` (used by the self-service client) is
compatible with protoc/protobuf version defined in the generator.

We'll manually change the version.

Verification:

```
export LOG_LEVEL=debug && npx --yes --package renovate -- renovate --platform=local

...
{
   "datasource": "maven",
   "depName": "com.google.protobuf:protobuf-bom",
   "currentValue": "3.25.4",
   "fileReplacePosition": 1523,
   "registryUrls": [
     "https://maven-central.storage-download.googleapis.com/maven2/",
     "https://maven-central.storage-download.googleapis.com/maven2",
     "https://repo1.maven.org/maven2",
     "https://repo.maven.apache.org/maven2"
   ],
   "depType": "import",
   "groupName": "protobuf.version",
   "editFile": "gapic-generator-java-pom-parent/pom.xml",
   "updates": [],
   "packageName": "com.google.protobuf:protobuf-bom",
   "skipReason": "disabled"
},
```
  • Loading branch information
JoeWang1127 authored Sep 11, 2024
1 parent badca93 commit 7996aab
Showing 1 changed file with 6 additions and 30 deletions.
36 changes: 6 additions & 30 deletions renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,29 +18,6 @@
],
"datasourceTemplate": "maven"
},
{
"customType": "regex",
"fileMatch": [
"^gax-java/dependencies\\.properties$"
],
"matchStrings": [
"version\\.com_google_protobuf=(?<currentValue>.+?)\\n"
],
"depNameTemplate": "com.google.protobuf:protobuf-java",
"datasourceTemplate": "maven"
},
{
"customType": "regex",
"fileMatch": [
"^\\.cloudbuild/library_generation/library_generation\\.Dockerfile$"
],
"matchStrings": [
"ARG PROTOC_VERSION=[\"']?(?<currentValue>.+?)[\"']?\\s+"
],
"datasourceTemplate": "github-releases",
"depNameTemplate": "protocolbuffers/protobuf",
"extractVersionTemplate": "^v(?<version>.*)$"
},
{
"customType": "regex",
"fileMatch": [
Expand Down Expand Up @@ -95,6 +72,12 @@
],
"enabled": false
},
{
"matchPackagePatterns": [
"^com.google.protobuf:"
],
"enabled": false
},
{
"matchPackagePatterns": [
"^com.google.guava:"
Expand Down Expand Up @@ -153,13 +136,6 @@
],
"groupName": "jackson dependencies"
},
{
"matchPackagePatterns": [
"^com.google.protobuf",
"^protocolbuffers/protobuf"
],
"groupName": "Protobuf dependencies"
},
{
"matchPackagePatterns": [
"^io.grpc"
Expand Down

0 comments on commit 7996aab

Please sign in to comment.