-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: do not use renovate to update protobuf #3190
Conversation
dependency.properties
dependencies.properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems to detach the version upgrade between the two files.
How about turning off Renovate for Protobuf? |
Do you mean |
I think we should detach the version upgrade between |
I can see the benefit of still using renovate bot as a hint to us that there is new version for prorobuf, instead of us manually checking if there is a newer version for protobuf. But eventually it would need manual change to upgrade, so I think either way is fine as long as we have a regular schedule to upgrade protobuf. |
The renovate pr can't bring code change since it comes from a fork, so I think it's fine to remove it from renovate. |
Quality Gate passed for 'gapic-generator-java-root'Issues Measures |
Quality Gate passed for 'java_showcase_integration_tests'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think the title is probably outdated now, right?
dependencies.properties
Thanks. Changed the title. |
In this PR: - Do not use renovate to update protobuf version in `gax-java/dependencies.properties`. We need to make sure the protobuf version in `gax-java/dependency.properties` (used by the self-service client) is compatible with protoc/protobuf version defined in the generator. We'll manually change the version. Verification: ``` export LOG_LEVEL=debug && npx --yes --package renovate -- renovate --platform=local ... { "datasource": "maven", "depName": "com.google.protobuf:protobuf-bom", "currentValue": "3.25.4", "fileReplacePosition": 1523, "registryUrls": [ "https://maven-central.storage-download.googleapis.com/maven2/", "https://maven-central.storage-download.googleapis.com/maven2", "https://repo1.maven.org/maven2", "https://repo.maven.apache.org/maven2" ], "depType": "import", "groupName": "protobuf.version", "editFile": "gapic-generator-java-pom-parent/pom.xml", "updates": [], "packageName": "com.google.protobuf:protobuf-bom", "skipReason": "disabled" }, ```
In this PR:
gax-java/dependencies.properties
.We need to make sure the protobuf version in
gax-java/dependency.properties
(used by the self-service client) is compatible with protoc/protobuf version defined in the generator.We'll manually change the version.
Verification: