Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try porting from rules_docker to rules_oci #130

Closed
ensonic opened this issue Apr 11, 2023 · 1 comment
Closed

Try porting from rules_docker to rules_oci #130

ensonic opened this issue Apr 11, 2023 · 1 comment
Assignees

Comments

@ensonic
Copy link
Contributor

ensonic commented Apr 11, 2023

In bazelbuild/rules_docker#2204 (comment) Alex Eage suggested to use https://github.com/bazel-contrib/rules_oci. A quick git grep rules_docker looks like it is not too much of a change (15 files).

@AlejoAsd AlejoAsd self-assigned this Apr 17, 2023
ensonic pushed a commit that referenced this issue Apr 20, 2023
Closes issue #130.

This PR alters the bazel build to use `rules_oci` to pull go base images
using a version that's decoupled for the `rules_docker` version. This
allows for us to update the base image version without having to depend
on `rules_docker`.

The latest version of both the `base` and `static` distroless version
was used to avoid unexpected breakages.

Note that `oci_rules` `pull` supports using the `latest` tag. The macro
that pulls base images can be configured to always pull the latest
images and be up to date if we are okay with assuming the potential
upstream breakage risks it introduces.

---------

Signed-off-by: Alejo Carballude <alejocarballude@gmail.com>
@ensonic
Copy link
Contributor Author

ensonic commented Jul 14, 2023

Fixed. Thanks @therjak

@ensonic ensonic closed this as completed Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants