Get base images for go builds independent of rules_docker version #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejo Carballude <alejocarballude@gmail.com>
ensonic
reviewed
Apr 20, 2023
Signed-off-by: Alejo Carballude <alejocarballude@gmail.com>
Signed-off-by: Alejo Carballude <alejocarballude@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #130.
This PR alters the bazel build to use
rules_ocito pull go base images using a version that's decoupled for therules_dockerversion. This allows for us to update the base image version without having to depend onrules_docker.The latest version of both the
baseandstaticdistroless version was used to avoid unexpected breakages.Note that
oci_rulespullsupports using thelatesttag. The macro that pulls base images can be configured to always pull the latest images and be up to date if we are okay with assuming the potential upstream breakage risks it introduces.