bug: fixed a race condition in database test (#690)

* bug: fixed a race condition in database test and plugin integration test Signed-off-by: eternal-flame-AD <yume@yumechi.jp> --------- Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
gotify · Sep 20, 2024 · a58b0be · a58b0be
1 parent a8a4fef
commit a58b0be
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/test/testdb/database.go b/test/testdb/database.go
@@ -30,15 +30,15 @@ type MessageBuilder struct {
 
 // NewDBWithDefaultUser creates a new test db instance with the default user.
 func NewDBWithDefaultUser(t *testing.T) *Database {
-	db, err := database.New("sqlite3", fmt.Sprintf("file:%s?mode=memory&cache=shared", fmt.Sprint(time.Now().Unix())), "admin", "pw", 5, true)
+	db, err := database.New("sqlite3", fmt.Sprintf("file:%s?mode=memory&cache=shared", fmt.Sprint(time.Now().UnixNano())), "admin", "pw", 5, true)
 	assert.Nil(t, err)
 	assert.NotNil(t, db)
 	return &Database{GormDatabase: db, t: t}
 }
 
 // NewDB creates a new test db instance.
 func NewDB(t *testing.T) *Database {
-	db, err := database.New("sqlite3", fmt.Sprintf("file:%s?mode=memory&cache=shared", fmt.Sprint(time.Now().Unix())), "admin", "pw", 5, false)
+	db, err := database.New("sqlite3", fmt.Sprintf("file:%s?mode=memory&cache=shared", fmt.Sprint(time.Now().UnixNano())), "admin", "pw", 5, false)
 	assert.Nil(t, err)
 	assert.NotNil(t, db)
 	return &Database{GormDatabase: db, t: t}

diff --git a/ui/src/tests/setup.ts b/ui/src/tests/setup.ts
@@ -65,7 +65,7 @@ const testPluginDir = (): {dir: string; generator: () => string} => {
     const dirName = 'gotifyplugin_' + random;
     const dir = path.join(testBuildPath, dirName);
     if (!fs.existsSync(dir)) {
-        fs.mkdirSync(dir, 0o755);
+        fs.mkdirSync(dir, {recursive: true, mode: 0o755});
     }
     return {
         dir,
@@ -105,7 +105,7 @@ const buildGoExecutable = (filename: string): Promise<void> => {
     const envGotify = process.env.GOTIFY_EXE;
     if (envGotify) {
         if (!fs.existsSync(testBuildPath)) {
-            fs.mkdirSync(testBuildPath);
+            fs.mkdirSync(testBuildPath, {recursive: true});
         }
         fs.copyFileSync(envGotify, filename);
         process.stdout.write(`### Copying ${envGotify} to ${filename}\n`);