Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fixed a race condition in database test #690

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

eternal-flame-AD
Copy link
Member

This won't work if two tests happened on the same second

Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
@eternal-flame-AD eternal-flame-AD requested a review from a team as a code owner September 20, 2024 05:51
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.46%. Comparing base (a8a4fef) to head (ef523c4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #690   +/-   ##
=======================================
  Coverage   80.46%   80.46%           
=======================================
  Files          56       56           
  Lines        2191     2191           
=======================================
  Hits         1763     1763           
  Misses        337      337           
  Partials       91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eternal-flame-AD eternal-flame-AD merged commit a58b0be into master Sep 20, 2024
4 checks passed
@eternal-flame-AD eternal-flame-AD deleted the database-test-race branch September 20, 2024 10:00
eternal-flame-AD added a commit that referenced this pull request Oct 16, 2024
* bug: fixed a race condition in database test and plugin integration test

Signed-off-by: eternal-flame-AD <yume@yumechi.jp>

---------

Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants