Add flow API support #2094
Merged
Add flow API support #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
reviewed
Aug 30, 2022
There was a problem hiding this comment.
I gave this a first pass, but I need more time to carefully review json_walker.go. It feels like there's more opportunities for it to reuse logic from river/internal/value and I want to take the time to find them so we don't have to spend too much time maintaining the json conversion.
rfratto
reviewed
Aug 30, 2022
|
Rewrote / changed pretty much the whole thing, its more code but I think much clearer on what is happening. |
rfratto
reviewed
Sep 6, 2022
rfratto
reviewed
Sep 8, 2022
rfratto
reviewed
Sep 13, 2022
|
(The CI is failing because of changes to the Makefile; you'll need to rebase on top of latest main) |
rfratto
reviewed
Sep 15, 2022
… isValid to hasValue.
rfratto
approved these changes
Sep 15, 2022
Co-authored-by: Robert Fratto <robertfratto@gmail.com>
Co-authored-by: Robert Fratto <robertfratto@gmail.com>
Co-authored-by: Robert Fratto <robertfratto@gmail.com>
Co-authored-by: Robert Fratto <robertfratto@gmail.com>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This adds the initial support for the flow API, necessary for the UI portion.
Fixes #2007.