Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flow API support #2094

Merged
merged 26 commits into from
Sep 16, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
76e3054
Flow API
mattdurham Aug 30, 2022
85bee3e
Fix #
mattdurham Aug 30, 2022
cb5b559
Fix spacing
mattdurham Aug 30, 2022
481cfe2
Fix spacing part 2
mattdurham Aug 30, 2022
75f3311
use predefined edges instead of calculating it again
mattdurham Sep 2, 2022
187491a
Use original edges
mattdurham Sep 2, 2022
e28a3e7
Rename and simplify converting to json
mattdurham Sep 2, 2022
2d73709
Rewrite to a longer but more easily understandable format.
mattdurham Sep 3, 2022
739a376
Unexport makeNumberKind
mattdurham Sep 3, 2022
af9249c
pr feedback
mattdurham Sep 7, 2022
1e88938
remove struct field and simplify
mattdurham Sep 8, 2022
1051fa1
simplify tests and fix gzip handling issue
mattdurham Sep 8, 2022
ba6a857
fix linting
mattdurham Sep 8, 2022
9e279c9
fix linting with receiver name
mattdurham Sep 8, 2022
e4f24a5
Simplified based on PR feedback
mattdurham Sep 13, 2022
b358c8e
Rename RiverValue to RiverField
mattdurham Sep 13, 2022
0ea4c7f
Merge branch 'main' into flow_api_pr
mattdurham Sep 14, 2022
d45ecff
PR feedback on changing exported fields to unexported and various oth…
mattdurham Sep 15, 2022
fdfe894
Fix linting for json
mattdurham Sep 15, 2022
b67716e
Changed json.RawMessage to not be a pointer and change name of missed…
mattdurham Sep 15, 2022
5790e1e
Update pkg/river/encoding/block.go
mattdurham Sep 16, 2022
1eafb8e
Update pkg/river/internal/value/number_value.go
mattdurham Sep 16, 2022
4340ffd
Update web/api/api.go
mattdurham Sep 16, 2022
aeac4ae
Update web/api/api.go
mattdurham Sep 16, 2022
882e7f5
Allow blocks to reference other arrays of blocks.
mattdurham Sep 16, 2022
67e24bb
Merge from remote
mattdurham Sep 16, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix linting
  • Loading branch information
mattdurham committed Sep 8, 2022
commit ba6a85717d09acd37ec0967941a7763a2afb8cc6
3 changes: 0 additions & 3 deletions pkg/river/encoding/array_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ import (
"github.com/stretchr/testify/require"
)

const number = "number"
const age = "age"

func TestSimpleArray(t *testing.T) {
intArr := make([]int, 10)
for i := 0; i < 10; i++ {
Expand Down
5 changes: 0 additions & 5 deletions pkg/river/encoding/encoding.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,6 @@ func isMapOrStruct(val value.Value) bool {
return val.Type() == value.TypeObject
}

func isStruct(val value.Value) bool {
// By checking the val.Type we can try to avoice the more expensive reflect.
return val.Type() == value.TypeObject && val.Reflect().Kind() == reflect.Struct
}

func convertRiverValue(val value.Value) (vf *ValueField, af *ArrayField, mf *MapField, err error) {
mattdurham marked this conversation as resolved.
Show resolved Hide resolved
if isFieldValue(val) {
vf, err = convertValue(val)
Expand Down