chore(phlare/pyroscope): rename phlare to pyroscope #4013
Conversation
There was a problem hiding this comment.
LGTM but I'd like to check with @cyriltovena that we're ready for the components to be renamed.
| @@ -19,6 +19,8 @@ Main (unreleased) | |||
| - Upgrade the embedded windows_exporter to commit 79781c6. (@jkroepke) | |||
|
|
|||
| - Prometheus exporters in Flow mode now set the `instance` label to a value similar to the one they used to have in Static mode (<hostname> by default, customized by some integrations). (@jcreixell) | |||
|
|
|||
| - `phlare.scrape` and `phlare.write` have been renamed to `pyroscope.scrape` and `pyroscope.scrape`. (@korniltsev) | |||
There was a problem hiding this comment.
This would be a breaking change, so we'd need to list it as such in a breaking change category listed before new features:
https://github.com/grafana/agent/blob/main/docs/developer/contributing.md#updating-the-changelog
There was a problem hiding this comment.
(Breaking changes also would need to be documented in the upgrade guide: https://github.com/grafana/agent/blob/main/docs/sources/flow/upgrade-guide.md)
There was a problem hiding this comment.
This item seems to be under "Breaking changes" section, so it is everything correct here? right?
I will update upgrade guide
There was a problem hiding this comment.
This item seems to be under "Breaking changes" section, so it is everything correct here? right?
Yes, sorry, I got confused by some of the other items 🤦 The only thing to do here is to update the upgrade guide.
github-actions
bot
added
the
frozen-due-to-age
PR Description
As part of phlare and pyroscope merging we are removing references to phlare, keeping it pyroscope.
component/phlarepackage tocomponent/pyroscopeWhich issue(s) this PR fixes
https://github.com/grafana/pyroscope-squad/issues/20
Notes to the Reviewer
Should we update upgrade guide?
PR Checklist