Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): update grafana-agent example #1963

Merged
merged 1 commit into from
May 30, 2023

Conversation

korniltsev
Copy link
Collaborator

remove phlare references in agent flow configuration
depends on grafana/agent#4013

Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@korniltsev
Copy link
Collaborator Author

I guess we should not merge until the agent is released

@github-actions
Copy link
Contributor

Flamegraph.com report

pyroscope-oss.frontend.cpu.json
See in flamegraph.com
pyroscope-oss.frontend.inuse_objects.json
See in flamegraph.com
pyroscope-oss.frontend.inuse_space.json
See in flamegraph.com

Created by Flamegraph.com Github Action

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 998.46 KB (0%) 20 s (0%) 4.8 s (-12.11% 🔽) 24.7 s
webapp/public/assets/app.css 19.9 KB (0%) 399 ms (0%) 0 ms (+100% 🔺) 399 ms
webapp/public/assets/styles.css 9.6 KB (0%) 192 ms (0%) 0 ms (+100% 🔺) 192 ms
packages/pyroscope-flamegraph/dist/index.js 625.75 KB (0%) 12.6 s (0%) 2.1 s (-4.52% 🔽) 14.7 s
packages/pyroscope-flamegraph/dist/index.node.js 626.45 KB (0%) 12.6 s (0%) 1.1 s (+54.2% 🔺) 13.6 s
packages/pyroscope-flamegraph/dist/index.css 8.14 KB (0%) 163 ms (0%) 0 ms (+100% 🔺) 163 ms

@github-actions
Copy link
Contributor

Flamegraph.com report

pyroscope-oss.alloc_objects.json
See in flamegraph.com
pyroscope-oss.alloc_space.json
See in flamegraph.com
pyroscope-oss.cpu.json
See in flamegraph.com
pyroscope-oss.goroutines.json
See in flamegraph.com
pyroscope-oss.inuse_objects.json
See in flamegraph.com
pyroscope-oss.inuse_space.json
See in flamegraph.com

Created by Flamegraph.com Github Action

@codecov-commenter
Copy link

Codecov Report

Merging #1963 (482fedb) into main (d6ab3f5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1963   +/-   ##
=======================================
  Coverage   60.50%   60.50%           
=======================================
  Files         177      177           
  Lines        4991     4991           
  Branches     1157     1157           
=======================================
  Hits         3020     3020           
  Misses       1959     1959           
  Partials       12       12           

@Rperry2174
Copy link
Contributor

I think its fine to merge since it's a little hidden for now (we don't link to it in docs yet) grafana agent should be updated soon

@Rperry2174 Rperry2174 merged commit 9bed3b7 into main May 30, 2023
@Rperry2174 Rperry2174 deleted the fix/examples_grafana_agent_rename branch May 30, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants