Fix static mode operational dash for agent-logs namespace #4300
Conversation
thampiotr
force-pushed
the
thampiotr/fix-agent-logs-operational-dash
branch
from
9855e7c
to
cb10989
Compare
| @@ -376,7 +376,7 @@ | |||
| }, | |||
| "yaxes": [ | |||
| { | |||
| "format": "short", | |||
| "format": "decbytes", | |||
There was a problem hiding this comment.
Nice! Finally we won't have to switch this manually 😄 @tpaschalis
| @@ -916,7 +916,7 @@ | |||
| "thresholds": [ ], | |||
| "timeFrom": null, | |||
| "timeShift": null, | |||
| "title": "Series/Config", | |||
| "title": "Series per Config", | |||
There was a problem hiding this comment.
TBH I personally find / notation such as Series/Config easier to read.
There was a problem hiding this comment.
It does look a bit worse when we have Heap Used /Series/Pod - looks like some kind of resource path or hierarchy. Since per fits on the screen, I'd prefer to use that.
There was a problem hiding this comment.
That's true, let's try out the "per" notation - I'd be happy with it
| @@ -284,7 +284,7 @@ | |||
| "thresholds": [ ], | |||
| "timeFrom": null, | |||
| "timeShift": null, | |||
| "title": "CPU", | |||
| "title": "CPU Usage [time/s]", | |||
There was a problem hiding this comment.
The only problem with including units in the title that I can think of, is that if someone edits an axis on the dashboard to have different units it might be confusing, or they'd have to update the title manually.
Wouldn't it be better to just set the unit in the Grafana settings for each axis, and then Grafana will just display them on each axis?
There was a problem hiding this comment.
I think if someone changes the axis, they can also change the title. I didn't put unit everywhere as it's sometimes obvious (e.g. bytes), but I think it's helpful for some less obvious charts, like CPU Usage which is "how many seconds of CPU time was used every second".
There was a problem hiding this comment.
Even in those cases I think I'd prefer to have the units on the actual axes instead of in the title. But I'm ok with having this in the title like this, it's still an improvement and I think it'll work ok.
| .addMultiTemplate('namespace', 'agent_build_info{cluster=~"$cluster"}', 'namespace') | ||
| .addMultiTemplate('container', 'agent_build_info{cluster=~"$cluster", namespace="$namespace"}', 'container') | ||
| .addMultiTemplate('pod', 'agent_build_info{cluster=~"$cluster", namespace="$namespace", container="$container"}', 'pod') |
There was a problem hiding this comment.
I think making the templates depending on each other helps better in navigating the hierarchy of k8s resources.
| @@ -284,7 +284,7 @@ | |||
| "thresholds": [ ], | |||
| "timeFrom": null, | |||
| "timeShift": null, | |||
| "title": "CPU", | |||
| "title": "CPU Usage [time/s]", | |||
There was a problem hiding this comment.
Even in those cases I think I'd prefer to have the units on the actual axes instead of in the title. But I'm ok with having this in the title like this, it's still an improvement and I think it'll work ok.
| @@ -916,7 +916,7 @@ | |||
| "thresholds": [ ], | |||
| "timeFrom": null, | |||
| "timeShift": null, | |||
| "title": "Series/Config", | |||
| "title": "Series per Config", | |||
There was a problem hiding this comment.
That's true, let's try out the "per" notation - I'd be happy with it
github-actions
bot
added
the
frozen-due-to-age
PR Description
When using dashboard mixin, on the "Agent Operational" dashboard, the
alloption forpodtemplate expects that pods havegrafana-agent-.*prefix. This is not always the case for every user. At the same time filtering pods in some way is useful, so this PR changes the templates so that they use the previous templates' scope to reduce list of values in the drop-down.Also gave some panels more descriptive names as I found some of them quite cryptic.
Notes to the Reviewer
PR Checklist