Fix static mode operational dash for agent-logs namespace #4300
generate dash
- Loading branch information
commit 000aa344b85494ccecdd0591a3c0af55a39f9bbb
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,7 +56,7 @@ | |
| "thresholds": [ ], | ||
| "timeFrom": null, | ||
| "timeShift": null, | ||
| "title": "GCs [count/s]", | ||
| "tooltip": { | ||
| "shared": true, | ||
| "sort": 2, | ||
|
|
@@ -132,7 +132,7 @@ | |
| "thresholds": [ ], | ||
| "timeFrom": null, | ||
| "timeShift": null, | ||
| "title": "Go Heap In Use", | ||
| "tooltip": { | ||
| "shared": true, | ||
| "sort": 2, | ||
|
|
@@ -284,7 +284,7 @@ | |
| "thresholds": [ ], | ||
| "timeFrom": null, | ||
| "timeShift": null, | ||
| "title": "CPU Usage [time/s]", | ||
| "tooltip": { | ||
| "shared": true, | ||
| "sort": 2, | ||
|
|
@@ -360,7 +360,7 @@ | |
| "thresholds": [ ], | ||
| "timeFrom": null, | ||
| "timeShift": null, | ||
| "title": "Working Set Size", | ||
| "tooltip": { | ||
| "shared": true, | ||
| "sort": 2, | ||
|
|
@@ -376,7 +376,7 @@ | |
| }, | ||
| "yaxes": [ | ||
| { | ||
| "format": "decbytes", | ||
|
There was a problem hiding this comment. Nice! Finally we won't have to switch this manually 😄 @tpaschalis |
||
| "label": null, | ||
| "logBase": 1, | ||
| "max": null, | ||
|
|
@@ -436,7 +436,7 @@ | |
| "thresholds": [ ], | ||
| "timeFrom": null, | ||
| "timeShift": null, | ||
| "title": "Promtail Bad Words", | ||
| "tooltip": { | ||
| "shared": true, | ||
| "sort": 2, | ||
|
|
@@ -524,7 +524,7 @@ | |
| "thresholds": [ ], | ||
| "timeFrom": null, | ||
| "timeShift": null, | ||
| "title": "Received Bytes [B/s]", | ||
| "tooltip": { | ||
| "shared": true, | ||
| "sort": 2, | ||
|
|
@@ -540,7 +540,7 @@ | |
| }, | ||
| "yaxes": [ | ||
| { | ||
| "format": "Bps", | ||
| "label": null, | ||
| "logBase": 1, | ||
| "max": null, | ||
|
|
@@ -600,7 +600,7 @@ | |
| "thresholds": [ ], | ||
| "timeFrom": null, | ||
| "timeShift": null, | ||
| "title": "Transmitted Bytes [B/s]", | ||
| "tooltip": { | ||
| "shared": true, | ||
| "sort": 2, | ||
|
|
@@ -616,7 +616,7 @@ | |
| }, | ||
| "yaxes": [ | ||
| { | ||
| "format": "Bps", | ||
| "label": null, | ||
| "logBase": 1, | ||
| "max": null, | ||
|
|
@@ -688,7 +688,7 @@ | |
| "thresholds": [ ], | ||
| "timeFrom": null, | ||
| "timeShift": null, | ||
| "title": "Heap Used per Series per Pod", | ||
| "tooltip": { | ||
| "shared": true, | ||
| "sort": 2, | ||
|
|
@@ -764,7 +764,7 @@ | |
| "thresholds": [ ], | ||
| "timeFrom": null, | ||
| "timeShift": null, | ||
| "title": "Avg Heap Used per Series", | ||
| "tooltip": { | ||
| "shared": true, | ||
| "sort": 2, | ||
|
|
@@ -840,7 +840,7 @@ | |
| "thresholds": [ ], | ||
| "timeFrom": null, | ||
| "timeShift": null, | ||
| "title": "Series Count per Pod", | ||
| "tooltip": { | ||
| "shared": true, | ||
| "sort": 2, | ||
|
|
@@ -916,7 +916,7 @@ | |
| "thresholds": [ ], | ||
| "timeFrom": null, | ||
| "timeShift": null, | ||
| "title": "Series per Config", | ||
|
There was a problem hiding this comment. TBH I personally find There was a problem hiding this comment. It does look a bit worse when we have There was a problem hiding this comment. That's true, let's try out the "per" notation - I'd be happy with it |
||
| "tooltip": { | ||
| "shared": true, | ||
| "sort": 2, | ||
|
|
@@ -992,7 +992,7 @@ | |
| "thresholds": [ ], | ||
| "timeFrom": null, | ||
| "timeShift": null, | ||
| "title": "Total Series", | ||
| "tooltip": { | ||
| "shared": true, | ||
| "sort": 2, | ||
|
|
@@ -1128,7 +1128,7 @@ | |
| "useTags": false | ||
| }, | ||
| { | ||
| "allValue": ".*agent.*", | ||
| "current": { | ||
| "selected": true, | ||
| "text": "All", | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only problem with including units in the title that I can think of, is that if someone edits an axis on the dashboard to have different units it might be confusing, or they'd have to update the title manually.
Wouldn't it be better to just set the unit in the Grafana settings for each axis, and then Grafana will just display them on each axis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if someone changes the axis, they can also change the title. I didn't put unit everywhere as it's sometimes obvious (e.g. bytes), but I think it's helpful for some less obvious charts, like CPU Usage which is "how many seconds of CPU time was used every second".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even in those cases I think I'd prefer to have the units on the actual axes instead of in the title. But I'm ok with having this in the title like this, it's still an improvement and I think it'll work ok.